Skip to contentSkip to conversation

Patch "net: fix a kernel infoleak in x25 module" has been added to the 3.14-stable tree

PATCH [email protected] 1 participant 1 message May 16, 2016

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

net: fix a kernel infoleak in x25 module

to the 3.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
net-fix-a-kernel-infoleak-in-x25-module.patch
and it can be found in the queue-3.14 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Mon May 16 14:28:53 PDT 2016

From: Kangjie Lu <[email protected]>
Date: Sun, 8 May 2016 12:10:14 -0400
Subject: net: fix a kernel infoleak in x25 module
Status: RO
Content-Length: 949
Lines: 29

From: Kangjie Lu <[email protected]>

[ Upstream commit 79e48650320e6fba48369fccf13fd045315b19b8 ]

Stack object "dte_facilities" is allocated in x25_rx_call_request(), which is supposed to be initialized in x25_negotiate_facilities. However, 5 fields (8 bytes in total) are not initialized. This object is then copied to userland via copy_to_user, thus infoleak occurs.

---
 net/x25/x25_facilities.c |    1 +
 1 file changed, 1 insertion(+)
net/x25/x25_facilities.c +1 -0
@@ -277,6 +277,7 @@ int x25_negotiate_facilities(struct sk_b
 
 	memset(&theirs, 0, sizeof(theirs));
 	memcpy(new, ours, sizeof(*new));
+	memset(dte, 0, sizeof(*dte));
 
 	len = x25_parse_facilities(skb, &theirs, dte, &x25->vc_facil_mask);
 	if (len < 0)

Patches currently in stable-queue which might be from [email protected] are

queue-3.14/net-fix-a-kernel-infoleak-in-x25-module.patch queue-3.14/net-fix-infoleak-in-llc.patch queue-3.14/net-fix-infoleak-in-rtnetlink.patch