Skip to contentSkip to conversation

Patch "packet: fix heap info leak in PACKET_DIAG_MCLIST sock_diag interface" has been added to the 3.14-stable tree

PATCH [email protected] 1 participant 1 message May 16, 2016

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

packet: fix heap info leak in PACKET_DIAG_MCLIST sock_diag interface

to the 3.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
packet-fix-heap-info-leak-in-packet_diag_mclist-sock_diag-interface.patch
and it can be found in the queue-3.14 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Mon May 16 14:28:53 PDT 2016

From: Mathias Krause <[email protected]>
Date: Sun, 10 Apr 2016 12:52:28 +0200
Subject: packet: fix heap info leak in PACKET_DIAG_MCLIST sock_diag interface
Status: RO
Content-Length: 1163
Lines: 33

From: Mathias Krause <[email protected]>

[ Upstream commit 309cf37fe2a781279b7675d4bb7173198e532867 ]

Because we miss to wipe the remainder of i->addr[] in packet_mc_add(), pdiag_put_mclist() leaks uninitialized heap bytes via the PACKET_DIAG_MCLIST netlink attribute.

Fix this by explicitly memset(0)ing the remaining bytes in i->addr[].

Fixes eea68e2f1a00 ("packet: Report socket mclist info via diag module")
Cc Eric W. Biederman <[email protected]>
Cc Pavel Emelyanov <[email protected]>
---
 net/packet/af_packet.c |    1 +
 1 file changed, 1 insertion(+)
net/packet/af_packet.c +1 -0
@@ -3153,6 +3153,7 @@ static int packet_mc_add(struct sock *sk
 	i->ifindex = mreq->mr_ifindex;
 	i->alen = mreq->mr_alen;
 	memcpy(i->addr, mreq->mr_address, i->alen);
+	memset(i->addr + i->alen, 0, sizeof(i->addr) - i->alen);
 	i->count = 1;
 	i->next = po->mclist;
 	po->mclist = i;

Patches currently in stable-queue which might be from [email protected] are

queue-3.14/packet-fix-heap-info-leak-in-packet_diag_mclist-sock_diag-interface.patch