Skip to contentSkip to conversation

Fix: unchecked return value in trace_clock_read64_monotonic

PATCH Jérémie Galarneau 1 participant 1 message May 18, 2016 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

Merged, but I also added a PERROR() and a TODO to report this error up the caller chain.

Thanks,
Jérémie

Quoted 30 lines · Mathieu Desnoyers

Found by Coverity:

CID 1311498 (#1 of 1): Unchecked return value (CHECKED_RETURN)1.
check_return: Calling clock_gettime without checking return value (as is done elsewhere 8 out of 9 times).

---
 src/bin/lttng-sessiond/ust-clock.h | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
src/bin/lttng-sessiond/ust-clock.h +4 -2
index 8493737..14ba71c 100644
@@ -57,7 +57,10 @@ uint64_t trace_clock_read64_monotonic(void)
 {
        struct timespec ts;
 
-       clock_gettime(CLOCK_MONOTONIC, &ts);
+       if (clock_gettime(CLOCK_MONOTONIC, &ts)) {
+               ts.tv_sec = 0;
+               ts.tv_nsec = 0;
+       }
        return ((uint64_t) ts.tv_sec * 1000000000ULL) + ts.tv_nsec;
 }
 
--

2.1.4

Signature · 7 lines
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com
_______________________________________________
lttng-dev mailing list
[email protected]
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev