Skip to contentSkip to conversation

usb: gadget: f_fs: Fix wrong check on reserved1 of OS_DESC_EXT_COMPAT

PATCH New Jim Lin 1 participant 1 message May 20, 2016 USB

lore
Share & tools
lore

Jim Lin

author
#0 lore raw

PATCH v2 1/1 usb: gadget: f_fs: Fix wrong check on reserved1 of OS_DESC_EXT_COMPAT

Current __ffs_data_do_os_desc() of f_fs.c will check reserved1 field of OS_DESC_EXT_COMPAT and return -EINVAL if it's 1.
But MS OS 1.0 Descriptors
http://msdn.microsoft.com/en-us/library/windows/hardware/gg463179.aspx
defines that field to be 1.

---
v2: Rewording on commit log. Original title is
usb: gadget: f_fs: Fix kernel panic for SuperSpeed

 drivers/usb/gadget/function/f_fs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/gadget/function/f_fs.c +1 -1
index 15b648c..bd969ef 100644
@@ -2051,7 +2051,7 @@ static int __ffs_data_do_os_desc(enum ffs_os_desc_type type,
 
 		if (len < sizeof(*d) ||
 		    d->bFirstInterfaceNumber >= ffs->interfaces_count ||
-		    d->Reserved1)
+		    !d->Reserved1)
 			return -EINVAL;
 		for (i = 0; i < ARRAY_SIZE(d->Reserved2); ++i)
 			if (d->Reserved2[i])
Signature · 1 line
1.9.1