Skip to contentSkip to conversation

ASoC: wm8985: add support for WM8758

PATCH Superseded Petr Kulhavy 3 participants 5 messages May 24, 2016 – May 26, 2016

Subsystems (3)

v4 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 ASoC: wm8985: add support for WM8758

The WM8758 chip is almost identical to WM8985 with the difference that it doesn't feature the AUX input. This patch adds the WM8758 support into the WM8985 driver.

The chip selection is done by the I2C name. The SPI probe supports only the WM8985.

---
v1: initial
v2: use chip type enum instead of chip structure
do not copy the complete controls, widget, routes but only the differences and add widgets dynamically using add_widgets()
v3: merge the wm8985_xxx_snd_controls into wm8985_common_snd_controls and wm8985_specific_snd_controls
in order to reduce the number of structures
use the static initialization in snd_soc_codec_driver for the common part
v4: avoid duplicating left/right_out_mixer and left/right_boost_mixer by moving the aux controls
at the end and providing shorter size for wm8758
do not move the high pass filter controls

 sound/soc/codecs/Kconfig  |   2 +-
 sound/soc/codecs/wm8985.c | 143 ++++++++++++++++++++++++++++++++++------------
 2 files changed, 109 insertions(+), 36 deletions(-)
sound/soc/codecs/Kconfig +1 -1
index 649e92a252ae..5947e0c94d02 100644
@@ -933,7 +933,7 @@ config SND_SOC_WM8983
 	tristate
 
 config SND_SOC_WM8985
-	tristate
+	tristate "Wolfson Microelectronics WM8985 and WM8758 codec driver"
 
 config SND_SOC_WM8988
 	tristate
sound/soc/codecs/wm8985.c +108 -35

288 lines not on this page · raw message

Signature · 1 line
1.9.1
Reviewed-by on v4 1/1
#1 lore raw
Quoted 9 lines · Petr Kulhavy

The WM8758 chip is almost identical to WM8985 with the difference that it doesn't feature the AUX input. This patch adds the WM8758 support into the WM8985 driver.

The chip selection is done by the I2C name. The SPI probe supports only the WM8985.

---

Thanks,
Charles

maintainer
#2 lore raw
In reply to Petr Kulhavy
Quoted 3 lines · Petr Kulhavy

The WM8758 chip is almost identical to WM8985 with the difference that it doesn't feature the AUX input. This patch adds the WM8758 support into the WM8985 driver.

This doesn't apply against current code, please check and resend.

#3 lore raw
Quoted 6 lines · Mark Brown
Quoted 3 lines · Petr Kulhavy

The WM8758 chip is almost identical to WM8985 with the difference that it doesn't feature the AUX input. This patch adds the WM8758 support into the WM8985 driver.

This doesn't apply against current code, please check and resend.

Hi Mark,

the patch is against the mainline kernel.
Do you mean I should apply it against this
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git ?

Thanks
Petr

maintainer
#4 lore raw
Quoted 7 lines · Petr Kulhavy
Quoted 1 line · Mark Brown

This doesn't apply against current code, please check and resend.

the patch is against the mainline kernel.
Do you mean I should apply it against this
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git ?

Yes, as covered in SubmittingPatches you should send patches that apply to the development version of code.