Skip to contentSkip to conversation

bin/release_scripts/release.py

PATCH In review Graydon, Tracy 2 participants 3 messages May 24, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bin/release_scripts/release.py

Get rid of the extraneous DL_BASE line. It's not used and should have been removed when I fixed the eclipse-plugin release path.

---
 bin/release_scripts/release.py | 1 -
 1 file changed, 1 deletion(-)
bin/release_scripts/release.py +0 -1
index 2b4d21c..89f68be 100755
@@ -351,7 +351,6 @@ if __name__ == '__main__':
     VHOSTS = "/srv/www/vhosts"
     AB_BASE = os.path.join(VHOSTS, "autobuilder.yoctoproject.org/pub/releases")
     DL_DIR = os.path.join(VHOSTS, "downloads.yoctoproject.org/releases")
-    DL_BASE = os.path.join(DL_DIR, "/releases/yocto")
     ADT_BASE = os.path.join(VHOSTS, "adtrepo.yoctoproject.org")
 
     # List of the directories we delete from all releases
Signature · 1 line
2.7.0
#1 lore raw
Quoted 13 lines · Tracy

Get rid of the extraneous DL_BASE line. It's not used and should have been removed when I fixed the eclipse-plugin release path.

---
 bin/release_scripts/release.py | 1 -

 1 file changed, 1 deletion(-)
bin/release_scripts/release.py +0 -0
index 2b4d21c..89f68be 100755
@@ -351,7 +351,6 @@ if __name__ == '__main__':
Quoted 8 lines

     VHOSTS = "/srv/www/vhosts"
     AB_BASE = os.path.join(VHOSTS, "autobuilder.yoctoproject.org/pub/releases")
     DL_DIR = os.path.join(VHOSTS, "downloads.yoctoproject.org/releases") -    DL_BASE = os.path.join(DL_DIR, "/releases/yocto") ADT_BASE = os.path.join(VHOSTS, "adtrepo.yoctoproject.org")
     # List of the directories we delete from all releases

Since your previous version of this patch has not yet been applied to master, I would think it would be better to incorporate this as part of a V2 of your previous patch, rather than a new patch on top of an as yet unapplied patch.

    -Bill

#2 lore raw
Quoted 23 lines · William C
Quoted 22 lines · Tracy

Get rid of the extraneous DL_BASE line. It's not used and should have been removed when I fixed the eclipse-plugin release path.

---
 bin/release_scripts/release.py | 1 -
 1 file changed, 1 deletion(-)
bin/release_scripts/release.py +0 -1
index 2b4d21c..89f68be 100755
@@ -351,7 +351,6 @@ if __name__ == '__main__':
     VHOSTS = "/srv/www/vhosts"
     AB_BASE = os.path.join(VHOSTS,
 "autobuilder.yoctoproject.org/pub/releases")
     DL_DIR = os.path.join(VHOSTS,
 "downloads.yoctoproject.org/releases")
-    DL_BASE = os.path.join(DL_DIR, "/releases/yocto")
     ADT_BASE = os.path.join(VHOSTS, "adtrepo.yoctoproject.org")
Quoted 7 lines
Quoted 1 line

# List of the directories we delete from all releases

Since your previous version of this patch has not yet been applied to master, I
would think it would be better to incorporate this as part of a V2 of your previous patch, rather than a new patch on top of an as yet unapplied patch.

Ah, you are right. I thought it had been pulled in already. I’ll rebase.

Quoted 2 lines

-Bill