Skip to contentSkip to conversation

Remove build time dependency in libpciaccess.

RFC In review [email protected] 2 participants 5 messages May 25, 2016

lore
Share & tools
lore
#0 lore raw

cover Remove build time dependency in libpciaccess.

From: Robert Foss <[email protected]>

Don't try to build overlay if libpciaccess is unavailable. This is useful for platforms that typically don't have pci hardware, like ARM platforms.

Robert Foss (2):
configure.ac: Add support for configure flag --disable-pciaccess. overlay/Makefile: Don't try to build overlay if libpciaccess is
unavailable.

 configure.ac        | 13 ++++++++++++-
 overlay/Makefile.am |  5 ++++-
 2 files changed, 16 insertions(+), 2 deletions(-)
Signature · 6 lines
2.7.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

RFC 1/2 configure.ac: Add support for configure flag --disable-pciaccess.

From: Robert Foss <[email protected]>

Add support for configure flag --disable-pciaccess and the associated automake define HAVE_PCIACCESS.

---
 configure.ac | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)
configure.ac +12 -1
index 11b1d46..e46bbd5 100644
@@ -101,7 +101,6 @@ fi
 AC_SUBST(ASSEMBLER_WARN_CFLAGS)
 
 PKG_CHECK_MODULES(DRM, [libdrm_intel >= 2.4.64 libdrm])
-PKG_CHECK_MODULES(PCIACCESS, [pciaccess >= 0.10])
 
 case "$target_cpu" in
 	x86*)
@@ -175,6 +174,18 @@ if test "x$VC4" = xyes; then
 fi
 AM_CONDITIONAL(HAVE_VC4, [test "x$VC4" = xyes])
 
+AC_ARG_ENABLE(pciaccess, AS_HELP_STRING([--disable-pciaccess],
+	      [Enable use of pci bus access using libpciaccess (default: auto)]),
+	      [PCIACCESS=$enableval], [PCIACCESS=auto])
+if test "x$PCIACCESS" = xauto; then
+	PKG_CHECK_EXISTS([pciaccess], [PCIACCESS=yes], [PCIACCESS=no])
+fi
+if test "x$PCIACCESS" = xyes; then
+	PKG_CHECK_MODULES(PCIACCESS, [pciaccess >= 0.10])
+	AC_DEFINE(HAVE_LIBPCIACCESS, 1, [Have libpciaccess support])
+fi
+AM_CONDITIONAL(HAVE_LIBPCIACCESS, [test "x$PCIACCESS" = xyes])
+
 # Define a configure option for the shader debugger
 AC_ARG_ENABLE(shader-debugger, AS_HELP_STRING([--enable-shader-debugger],
 	      [Enable shader debugging support [autodetected]]),
Signature · 6 lines
2.7.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#2 lore raw

RFC 2/2 overlay/Makefile: Don't try to build overlay if libpciaccess is unavailable.

In reply to [email protected]

From: Robert Foss <[email protected]>

Don't try to build overlay if libpciaccess is unavailable.
This is useful for platforms that typically don't have pci hardware, like ARM platforms.

---
 overlay/Makefile.am | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
overlay/Makefile.am +4 -1
index c926557..a60c6b8 100644
@@ -1,5 +1,8 @@
+
 if BUILD_OVERLAY
-bin_PROGRAMS = intel-gpu-overlay
+	if HAVE_LIBPCIACCESS
+		bin_PROGRAMS = intel-gpu-overlay
+	endif
 endif
 
 AM_CPPFLAGS = -I.
Signature · 6 lines
2.7.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#3 lore raw

Re: [RFC i-g-t 2/2] overlay/Makefile: Don't try to build overlay if libpciaccess is unavailable.

Quoted 5 lines · On Wed, May 25, 2016 at 02:43:59PM -0400, [email protected] wrote:

From: Robert Foss <[email protected]>

Don't try to build overlay if libpciaccess is unavailable.
This is useful for platforms that typically don't have pci hardware, like ARM platforms.

Ok, I should be able to make the dependency optional. -Chris

Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#4 lore raw

Fwd: Re: [RFC i-g-t 2/2] overlay/Makefile: Don't try to build overlay if libpciaccess is unavailable.

Forward to ML.

Quoted 5 lines · On Wed, May 25, 2016 at 02:43:59PM -0400, [email protected] wrote:

From: Robert Foss <[email protected]>

Don't try to build overlay if libpciaccess is unavailable.
This is useful for platforms that typically don't have pci hardware, like ARM platforms.

Ok, I should be able to make the dependency optional. -Chris

Signature · 7 lines
Chris Wilson, Intel Open Source Technology Centre


_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx