Skip to contentSkip to conversation

Patch "md: md.c: fix oops in mddev_suspend for raid0" has been added to the 4.6-stable tree

PATCH [email protected] 1 participant 1 message May 30, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

md: md.c: fix oops in mddev_suspend for raid0

to the 4.6-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
md-md.c-fix-oops-in-mddev_suspend-for-raid0.patch
and it can be found in the queue-4.6 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 092398dce8c2406bfb0c9eebc3e764ff2ddb62a8 Mon Sep 17 00:00:00 2001

From: Heinz Mauelshagen <[email protected]>
Date: Tue, 3 May 2016 19:43:57 +0200
Subject: md: md.c: fix oops in mddev_suspend for raid0

From: Heinz Mauelshagen <[email protected]>

commit 092398dce8c2406bfb0c9eebc3e764ff2ddb62a8 upstream.

Introduced by upstream commit 70d9798b95562abac005d4ba71d28820f9a201eb

The raid0 personality does not create mddev->thread as oposed to other personalities leading to its unconditional access in mddev_suspend() causing an oops.

Patch checks for mddev->thread in order to keep the intention of aforementioned commit.

Fixes 70d9798b9556 ("MD: warn for potential deadlock")
---
 drivers/md/md.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/md/md.c +1 -1
@@ -307,7 +307,7 @@ static blk_qc_t md_make_request(struct r
  */
 void mddev_suspend(struct mddev *mddev)
 {
-	WARN_ON_ONCE(current == mddev->thread->tsk);
+	WARN_ON_ONCE(mddev->thread && current == mddev->thread->tsk);
 	if (mddev->suspended++)
 		return;
 	synchronize_rcu();

Patches currently in stable-queue which might be from [email protected] are

queue-4.6/md-md.c-fix-oops-in-mddev_suspend-for-raid0.patch