Skip to contentSkip to conversation

alsabat: fix a possible memory leak

PATCH Applied [email protected] 2 participants 2 messages Jun 1, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 alsabat: fix a possible memory leak

From: "Lu, Han" <[email protected]>

Fix a possible memory leak in generate_sine_wave(). Memory free was ignored when the function return an error.

bat/signal.c +4 -3
index a47ba97..61d2824 100644
@@ -168,16 +168,17 @@ int generate_sine_wave(struct bat *bat, int frames, void *buf)
 	/* reorder samples to interleaved mode */
 	err = reorder(bat, sinus_f, frames);
 	if (err != 0)
-		return err;
+		goto exit;
 
 	/* adjust amplitude and offset of waveform */
 	err = adjust_waveform(bat, sinus_f, frames);
 	if (err != 0)
-		return err;
+		goto exit;
 
 	bat->convert_float_to_sample(sinus_f, buf, frames, bat->channels);
 
+exit:
 	free(sinus_f);
 
-	return 0;
+	return err;
 }
Signature · 1 line
2.5.0