Skip to contentSkip to conversation

FAILED: patch "[PATCH] PKCS#7: fix missing break on OID_sha224 case" failed to apply to 4.4-stable tree

PATCH [email protected] 1 participant 1 message Jun 4, 2016

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

The patch below does not apply to the 4.4-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

Quoted 1 line

From 06af9b0f4949b85b20107e6d75f5eba15111d220 Mon Sep 17 00:00:00 2001

From: Colin Ian King <[email protected]>
Date: Fri, 18 Mar 2016 15:51:31 +0000
Subject: [PATCH] PKCS#7: fix missing break on OID_sha224 case

The OID_sha224 case is missing a break and it falls through to the -ENOPKG error default. Since HASH_ALGO_SHA224 seems to be supported, this looks like an unintentional missing break.

Fixes 07f081fb5057 ("PKCS#7: Add OIDs for sha224, sha284 and sha512 hash algos and use them")
Cc <[email protected]> # 4.2+
crypto/asymmetric_keys/pkcs7_parser.c +1 -0
index 40de03f49ff8..bdd0d753ce5d 100644
@@ -237,6 +237,7 @@ int pkcs7_sig_note_digest_algo(void *context, size_t hdrlen,
 		break;
 	case OID_sha224:
 		ctx->sinfo->sig.hash_algo = "sha224";
+		break;
 	default:
 		printk("Unsupported digest algo: %u\n", ctx->last_oid);
 		return -ENOPKG;