Skip to contentSkip to conversation

Patch "clk: at91: fix check of clk_register() returned value" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Jun 4, 2016

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

clk: at91: fix check of clk_register() returned value

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
clk-at91-fix-check-of-clk_register-returned-value.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From cb0ceaf77d93964a0d00477c79f4499123f6159c Mon Sep 17 00:00:00 2001

From: Vladimir Zapolskiy <[email protected]>
Date: Tue, 8 Mar 2016 01:41:29 +0200
Subject: clk: at91: fix check of clk_register() returned value

From: Vladimir Zapolskiy <[email protected]>

commit cb0ceaf77d93964a0d00477c79f4499123f6159c upstream.

The clk_register() function returns a valid pointer to struct clk or ERR_PTR() error code, this makes a check for returned NULL value useless and may lead to oops on error path.

Fixes bcc5fd49a0fd ("clk: at91: add a driver for the h32mx clock")
---
 drivers/clk/at91/clk-h32mx.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/at91/clk-h32mx.c +1 -1
@@ -116,7 +116,7 @@ void __init of_sama5d4_clk_h32mx_setup(s
 	h32mxclk->pmc = pmc;
 
 	clk = clk_register(NULL, &h32mxclk->hw);
-	if (!clk) {
+	if (IS_ERR(clk)) {
 		kfree(h32mxclk);
 		return;
 	}

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/clk-at91-fix-check-of-clk_register-returned-value.patch