Skip to contentSkip to conversation

Patch "cpuidle: Indicate when a device has been unregistered" has been added to the 4.6-stable tree

PATCH [email protected] 1 participant 1 message Jun 4, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

cpuidle: Indicate when a device has been unregistered

to the 4.6-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
cpuidle-indicate-when-a-device-has-been-unregistered.patch
and it can be found in the queue-4.6 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From c998c07836f985b24361629dc98506ec7893e7a0 Mon Sep 17 00:00:00 2001

From: Dave Gerlach <[email protected]>
Date: Tue, 5 Apr 2016 14:05:38 -0500
Subject: cpuidle: Indicate when a device has been unregistered

From: Dave Gerlach <[email protected]>

commit c998c07836f985b24361629dc98506ec7893e7a0 upstream.

Currently the 'registered' member of the cpuidle_device struct is set to 1 during cpuidle_register_device. In this same function there are checks to see if the device is already registered to prevent duplicate calls to register the device, but this value is never set to 0 even on unregister of the device. Because of this, any attempt to call cpuidle_register_device after a call to cpuidle_unregister_device will fail which shouldn't be the case.

To prevent this, set registered to 0 when the device is unregistered.

Fixes c878a52d3c7c (cpuidle: Check if device is already registered)
---
 drivers/cpuidle/cpuidle.c |    2 ++
 1 file changed, 2 insertions(+)
drivers/cpuidle/cpuidle.c +2 -0
@@ -433,6 +433,8 @@ static void __cpuidle_unregister_device(
 	list_del(&dev->device_list);
 	per_cpu(cpuidle_devices, dev->cpu) = NULL;
 	module_put(drv->owner);
+
+	dev->registered = 0;
 }
 
 static void __cpuidle_device_init(struct cpuidle_device *dev)

Patches currently in stable-queue which might be from [email protected] are

queue-4.6/cpuidle-indicate-when-a-device-has-been-unregistered.patch