Skip to contentSkip to conversation

Patch "PKCS#7: fix missing break on OID_sha224 case" has been added to the 4.6-stable tree

PATCH [email protected] 1 participant 1 message Jun 4, 2016

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

PKCS#7: fix missing break on OID_sha224 case

to the 4.6-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:

     pkcs-7-fix-missing-break-on-oid_sha224-case.patch

and it can be found in the queue-4.6 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 06af9b0f4949b85b20107e6d75f5eba15111d220 Mon Sep 17 00:00:00 2001

From: Colin Ian King <[email protected]>
Date: Fri, 18 Mar 2016 15:51:31 +0000
Subject: PKCS#7: fix missing break on OID_sha224 case

From: Colin Ian King <[email protected]>

commit 06af9b0f4949b85b20107e6d75f5eba15111d220 upstream.

The OID_sha224 case is missing a break and it falls through to the -ENOPKG error default. Since HASH_ALGO_SHA224 seems to be supported, this looks like an unintentional missing break.

Fixes 07f081fb5057 ("PKCS#7: Add OIDs for sha224, sha284 and sha512 hash algos and use them")
---
 crypto/asymmetric_keys/pkcs7_parser.c |    1 +
 1 file changed, 1 insertion(+)
crypto/asymmetric_keys/pkcs7_parser.c +1 -0
@@ -237,6 +237,7 @@ int pkcs7_sig_note_digest_algo(void *con
 		break;
 	case OID_sha224:
 		ctx->sinfo->sig.hash_algo = "sha224";
+		break;
 	default:
 		printk("Unsupported digest algo: %u\n", ctx->last_oid);
 		return -ENOPKG;

Patches currently in stable-queue which might be from [email protected] are

queue-4.6/pkcs-7-fix-missing-break-on-oid_sha224-case.patch