Skip to contentSkip to conversation

Patch "Revert "lpfc: Delete unnecessary checks before the function call mempool_destroy"" has been added to the 4.6-stable tree

PATCH [email protected] 1 participant 1 message Jun 4, 2016

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

Revert "lpfc: Delete unnecessary checks before the function call mempool_destroy"

to the 4.6-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
revert-lpfc-delete-unnecessary-checks-before-the-function-call-mempool_destroy.patch
and it can be found in the queue-4.6 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From d65c8fff867a6450c58ce31572e883148a445ddf Mon Sep 17 00:00:00 2001

From: "Martin K. Petersen" <[email protected]>
Date: Mon, 9 May 2016 21:39:43 -0400
Subject: Revert "lpfc: Delete unnecessary checks before the function call mempool_destroy"

From: Martin K. Petersen <[email protected]>

commit d65c8fff867a6450c58ce31572e883148a445ddf upstream.

This reverts commit 9be321819c43417432a8376428b90fe3fe3a3510 which caused a regression on hardware using the SLI3 interface.

---
 drivers/scsi/lpfc/lpfc_mem.c |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/scsi/lpfc/lpfc_mem.c +4 -2
@@ -231,13 +231,15 @@ lpfc_mem_free(struct lpfc_hba *phba)
 	if (phba->lpfc_hbq_pool)
 		pci_pool_destroy(phba->lpfc_hbq_pool);
 	phba->lpfc_hbq_pool = NULL;
-	mempool_destroy(phba->rrq_pool);
+
+	if (phba->rrq_pool)
+		mempool_destroy(phba->rrq_pool);
 	phba->rrq_pool = NULL;
 
 	/* Free NLP memory pool */
 	mempool_destroy(phba->nlp_mem_pool);
 	phba->nlp_mem_pool = NULL;
-	if (phba->sli_rev == LPFC_SLI_REV4) {
+	if (phba->sli_rev == LPFC_SLI_REV4 && phba->active_rrq_pool) {
 		mempool_destroy(phba->active_rrq_pool);
 		phba->active_rrq_pool = NULL;
 	}

Patches currently in stable-queue which might be from [email protected] are

queue-4.6/aacraid-fix-for-kdump-driver-hang.patch queue-4.6/aacraid-start-adapter-after-updating-number-of-msix-vectors.patch queue-4.6/revert-lpfc-delete-unnecessary-checks-before-the-function-call-mempool_destroy.patch queue-4.6/aacraid-fix-for-aac_command_thread-hang.patch queue-4.6/aacraid-relinquish-cpu-during-timeout-wait.patch