Patch "drm/vmwgfx: Fix order of operation" has been added to the 4.4-stable tree
Subsystems (4)
This is a note to let you know that I've just added the patch titled
drm/vmwgfx: Fix order of operation
to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
drm-vmwgfx-fix-order-of-operation.patch
and it can be found in the queue-4.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
7851496a32319237456919575e5f4ba62f74cc7dMon Sep 17 00:00:00 2001
From: Sinclair Yeh <[email protected]>
Date: Thu, 21 Apr 2016 11:29:31 -0700
Subject: drm/vmwgfx: Fix order of operation
From: Sinclair Yeh <[email protected]>
commit 7851496a32319237456919575e5f4ba62f74cc7d upstream.
mode->hdisplay * (var->bits_per_pixel + 7) gets evaluated before the division, potentially making the pitch larger than it should be.
Since the original intention is to do a div-round-up, just use the macro instead.
--- drivers/gpu/drm/vmwgfx/vmwgfx_fb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/vmwgfx/vmwgfx_fb.c +3 -3
@@ -573,9 +573,9 @@ static int vmw_fb_set_par(struct fb_info mode = old_mode; old_mode =NULL ; }else if (!vmw_kms_validate_mode_vram (vmw_priv, - mode->hdisplay * - (var->bits_per_pixel +7 ) /8 , - mode->vdisplay)) { + mode->hdisplay * +DIV_ROUND_UP (var->bits_per_pixel,8 ), + mode->vdisplay)) {drm_mode_destroy (vmw_priv->dev, mode);return -EINVAL ; }
Patches currently in stable-queue which might be from [email protected] are
queue-4.4/drm-vmwgfx-use-vmw_cmd_dx_cid_check-for-query-commands.patch queue-4.4/drm-vmwgfx-fix-order-of-operation.patch queue-4.4/drm-vmwgfx-enable-svga_3d_cmd_dx_set_predication.patch