Skip to contentSkip to conversation

geis: add CFLAG to ignore misleading indentations

PATCH In review Derek Straka 3 participants 5 messages Jun 9, 2016 – Jun 17, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 geis: add CFLAG to ignore misleading indentations

---
 meta-oe/recipes-support/canonical-multitouch/geis_2.2.17.bb | 2 ++
 1 file changed, 2 insertions(+)
meta-oe/recipes-support/canonical-multitouch/geis_2.2.17.bb +2 -0
index bc88143..9b087a8 100644
@@ -24,6 +24,8 @@ SRC_URI[md5sum] = "2ff9d76a3ea5794516bb02c9d1924faf"
 SRC_URI[sha256sum] = "8a60f5683852094038904e690d23cc5a90a980fc52da67f0f28890baa25c70eb"
 
 EXTRA_OECONF = "--disable-integration-tests"
+TARGET_CFLAGS += "-Wno-error=misleading-indentation"
+
 
 FILES_${PN}-bin = "${bindir}"
 RDEPENDS_${PN}-bin = " \
Signature · 1 line
1.9.1
#1 lore raw
Quoted 15 lines · Derek Straka

---
meta-oe/recipes-support/canonical-multitouch/geis_2.2.17.bb | 2 ++

1 file changed, 2 insertions(+)
meta-oe/recipes-support/canonical-multitouch/geis_2.2.17.bb +0 -0
index bc88143..9b087a8 100644
@@ -24,6 +24,8 @@ SRC_URI[md5sum] = "2ff9d76a3ea5794516bb02c9d1924faf"

SRC_URI[sha256sum] = "8a60f5683852094038904e690d23cc5a90a980fc52da67f0f28890baa25c70eb"

Quoted 2 lines

EXTRA_OECONF = "--disable-integration-tests" +TARGET_CFLAGS += "-Wno-error=misleading-indentation”

why not fix the code

Quoted 13 lines

+

FILES_${PN}-bin = "${bindir}"
RDEPENDS_${PN}-bin = " \
--
1.9.1

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#2 lore raw

It didn't seem worthwhile to create a patchset to fix whitespace issues. I can create the patches if people prefer that to suppressing the error.

-Derek

Quoted 37 lines · Khem Raj

Review

Quoted 9 lines · Derek Straka

---
meta-oe/recipes-support/canonical-multitouch/geis_2.2.17.bb | 2 ++

1 file changed, 2 insertions(+)
(quoted diff) +0 -0

b/meta-oe/recipes-support/canonical-multitouch/geis_2.2.17.bb

Quoted 5 lines

index bc88143..9b087a8 100644

meta-oe/recipes-support/canonical-multitouch/geis_2.2.17.bb +0 -0
@@ -24,6 +24,8 @@ SRC_URI[md5sum] = "2ff9d76a3ea5794516bb02c9d1924faf"

SRC_URI[sha256sum] =

"8a60f5683852094038904e690d23cc5a90a980fc52da67f0f28890baa25c70eb"

Quoted 3 lines

EXTRA_OECONF = "--disable-integration-tests" +TARGET_CFLAGS += "-Wno-error=misleading-indentation”

why not fix the code

Quoted 13 lines

+

FILES_${PN}-bin = "${bindir}"
RDEPENDS_${PN}-bin = " \
--
1.9.1

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#3 lore raw
Quoted 2 lines · Derek Straka

It didn't seem worthwhile to create a patchset to fix whitespace issues. I can create the patches if people prefer that to suppressing the error.

I would prefer fixing the issue, but I'm very grateful for your changes fixing the build failures (in any way), there are only very few people actually sending any fixes. And simple work around is still better than even more PNBLACKLISTs.

Thanks!

Quoted 46 lines

-Derek

Quoted 37 lines · Khem Raj

Review

Quoted 9 lines · Derek Straka

---
meta-oe/recipes-support/canonical-multitouch/geis_2.2.17.bb | 2 ++

1 file changed, 2 insertions(+)
(quoted diff) +0 -0

b/meta-oe/recipes-support/canonical-multitouch/geis_2.2.17.bb

Quoted 5 lines

index bc88143..9b087a8 100644

meta-oe/recipes-support/canonical-multitouch/geis_2.2.17.bb +0 -0
@@ -24,6 +24,8 @@ SRC_URI[md5sum] = "2ff9d76a3ea5794516bb02c9d1924faf"

SRC_URI[sha256sum] =

"8a60f5683852094038904e690d23cc5a90a980fc52da67f0f28890baa25c70eb"

Quoted 3 lines

EXTRA_OECONF = "--disable-integration-tests" +TARGET_CFLAGS += "-Wno-error=misleading-indentation”

why not fix the code

Quoted 13 lines

+

FILES_${PN}-bin = "${bindir}"
RDEPENDS_${PN}-bin = " \
--
1.9.1

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Signature · 4 lines
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#4 lore raw
In reply to Derek Straka
Quoted 4 lines · Derek Straka

It didn't seem worthwhile to create a patchset to fix whitespace issues. I can create the patches if people prefer that to suppressing the error.

Usually yes for OE it doesn't matter, however upstream of these components will prefer it, and would be good fix once for all and submit it to upstream directly

Quoted 39 lines

-Derek

Quoted 14 lines · On Fri, Jun 17, 2016 at 12:17 AM, Khem Raj <[email protected]…

On Jun 8, 2016, at 6:28 PM, Derek Straka <[email protected] <mailto:[email protected]>> wrote:

Signed-off-by Derek Straka <[email protected] <mailto:[email protected]>>

---
meta-oe/recipes-support/canonical-multitouch/geis_2.2.17.bb <http://geis_2.2.17.bb/> | 2 ++

1 file changed, 2 insertions(+)
meta-oe/recipes-support/canonical-multitouch/geis_2.2.17.bb <http://geis_2.2.17.bb/> +0 -0
index bc88143..9b087a8 100644
@@ -24,6 +24,8 @@ SRC_URI[md5sum] = "2ff9d76a3ea5794516bb02c9d1924faf"

SRC_URI[sha256sum] = "8a60f5683852094038904e690d23cc5a90a980fc52da67f0f28890baa25c70eb"

Quoted 2 lines

EXTRA_OECONF = "--disable-integration-tests" +TARGET_CFLAGS += "-Wno-error=misleading-indentation”

why not fix the code

Quoted 13 lines

+

FILES_${PN}-bin = "${bindir}"
RDEPENDS_${PN}-bin = " \
--
1.9.1

--
_______________________________________________
Openembedded-devel mailing list
[email protected] <mailto:[email protected]>
http://lists.openembedded.org/mailman/listinfo/openembedded-devel <http://lists.openembedded.org/mailman/listinfo/openembedded-devel>