Skip to contentSkip to conversation

Patch "bridge: Don't insert unnecessary local fdb entry on changing mac address" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Jun 17, 2016

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

bridge: Don't insert unnecessary local fdb entry on changing mac address

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
bridge-don-t-insert-unnecessary-local-fdb-entry-on-changing-mac-address.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Fri Jun 17 11:18:18 PDT 2016

From: Toshiaki Makita <[email protected]>
Date: Tue, 7 Jun 2016 19:14:17 +0900
Subject: bridge: Don't insert unnecessary local fdb entry on changing mac address

From: Toshiaki Makita <[email protected]>

[ Upstream commit 0b148def403153a4d1565f1640356cb78ce5109f ]

The missing br_vlan_should_use() test caused creation of an unneeded local fdb entry on changing mac address of a bridge device when there is a vlan which is configured on a bridge port but not on the bridge device.

Fixes 2594e9064a57 ("bridge: vlan: add per-vlan struct and move to rhashtables")
---
 net/bridge/br_fdb.c |    2 ++
 1 file changed, 2 insertions(+)
net/bridge/br_fdb.c +2 -0
@@ -278,6 +278,8 @@ void br_fdb_change_mac_address(struct ne
 	 * change from under us.
 	 */
 	list_for_each_entry(v, &vg->vlan_list, vlist) {
+		if (!br_vlan_should_use(v))
+			continue;
 		f = __br_fdb_get(br, br->dev->dev_addr, v->vid);
 		if (f && f->is_local && !f->dst)
 			fdb_delete_local(br, NULL, f);

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/bridge-don-t-insert-unnecessary-local-fdb-entry-on-changing-mac-address.patch