Patch "gpio: bcm-kona: fix bcm_kona_gpio_reset() warnings" has been added to the 4.6-stable tree
Subsystems (4)
This is a note to let you know that I've just added the patch titled
gpio: bcm-kona: fix bcm_kona_gpio_reset() warnings
to the 4.6-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
gpio-bcm-kona-fix-bcm_kona_gpio_reset-warnings.patch
and it can be found in the queue-4.6 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
b66b2a0adf0e48973b582e055758b9907a7eee7cMon Sep 17 00:00:00 2001
From: Ben Dooks <[email protected]>
Date: Tue, 7 Jun 2016 17:22:17 +0100
Subject: gpio: bcm-kona: fix bcm_kona_gpio_reset() warnings
From: Ben Dooks <[email protected]>
commit b66b2a0adf0e48973b582e055758b9907a7eee7c upstream.
The bcm_kona_gpio_reset() calls bcm_kona_gpio_write_lock_regs() with what looks like the wrong parameter. The write_lock_regs function takes a pointer to the registers, not the bcm_kona_gpio structure.
Fix the warning, and probably bug by changing the function to pass reg_base instead of kona_gpio, fixing the following warning:
drivers/gpio/gpio-bcm-kona.c:550:47: warning: incorrect type in argument 1
(different address spaces)
expected void [noderef] <asn:2>*reg_base
got struct bcm_kona_gpio *kona_gpio
warning: incorrect type in argument 1 (different address spaces) expected void [noderef] <asn:2>*reg_base
got struct bcm_kona_gpio *kona_gpio
--- drivers/gpio/gpio-bcm-kona.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpio/gpio-bcm-kona.c +2 -2
@@ -546,11 +546,11 @@ static void bcm_kona_gpio_reset(struct b/* disable interrupts and clear status */ for (i =0 ; i < kona_gpio->num_bank; i++) {/* Unlock the entire bank first */ -bcm_kona_gpio_write_lock_regs (kona_gpio, i,UNLOCK_CODE ); +bcm_kona_gpio_write_lock_regs (reg_base, i,UNLOCK_CODE );writel (0xffffffff , reg_base +GPIO_INT_MASK (i));writel (0xffffffff , reg_base +GPIO_INT_STATUS (i));/* Now re-lock the bank */ -bcm_kona_gpio_write_lock_regs (kona_gpio, i,LOCK_CODE ); +bcm_kona_gpio_write_lock_regs (reg_base, i,LOCK_CODE ); } }
Patches currently in stable-queue which might be from [email protected] are
queue-4.6/gpio-bcm-kona-fix-bcm_kona_gpio_reset-warnings.patch