bundles/pycaml/: use .NOTPARALLEL on bundles
PATCH v3 1/1 bundles/pycaml/: use .NOTPARALLEL on bundles
We need to disable parallel builds on the preparation of bundles. This fixes parallel compilation when using 32 threads on a 32-core system and on an 8 core system:
The error:
make[6]: Entering directory '/home/mcgrof/coccinelle/bundles/pycaml' /usr/bin/ocamlopt.opt -I chemoelectric-pycaml-8614105 -cclib -lpycaml_stubs -ccopt -I/usr/include/python2.7 -ccopt -I/usr/include/x86_64-linux-gnu/python2.7 -cclib -lpython2.7 -c chemoelectric-pycaml-8614105/pycaml.ml -o chemoelectric-pycaml-8614105/pycaml.cmx
make[6]: *** No rule to make target 'chemoelectric-pycaml-8614105/pycaml.a', needed by 'all-opt-build-targets'. Stop.
make[6]: *** Waiting for unfinished jobs....
make[6]: Leaving directory '/home/mcgrof/coccinelle/bundles/pycaml' ../Makefile.bundles:33: recipe for target 'all.opt' failed make[5]: *** [all.opt] Error 2
make[5]: Leaving directory '/home/mcgrof/coccinelle/bundles/pycaml' Makefile:186: recipe for target '/home/mcgrof/coccinelle/bundles/pycaml/.opt' failed make[4]: *** [/home/mcgrof/coccinelle/bundles/pycaml/.opt] Error 2 make[4]: Leaving directory '/home/mcgrof/coccinelle' Makefile:180: recipe for target 'subdirs.opt' failed make[3]: *** [subdirs.opt] Error 1
make[3]: Leaving directory '/home/mcgrof/coccinelle' Makefile:163: recipe for target 'opt-compil' failed make[2]: *** [opt-compil] Error 2
make[2]: Leaving directory '/home/mcgrof/coccinelle' Makefile:143: recipe for target 'all-release' failed make[1]: *** [all-release] Error 2
make[1]: Leaving directory '/home/mcgrof/coccinelle' Makefile:121: recipe for target 'all' failed
make: *** [all] Error 2
--- bundles/menhirLib/Makefile | 1 + bundles/parmap/Makefile | 1 + bundles/pcre/Makefile | 1 + bundles/pycaml/Makefile | 1 + 4 files changed, 4 insertions(+)
bundles/menhirLib/Makefile +1 -0
@@ -33,6 +33,7 @@ include ../Makefile.bundles depend: .depend @$(MAKE) all-build +.NOTPARALLEL: .prepare .prepare: $(MARKER) echo "let libdir = \"$(shell pwd\)\"" > $(SRC_DIR)/installation.ml echo "let ocamlfind = false" >> $(SRC_DIR)/installation.ml
bundles/parmap/Makefile +1 -0
@@ -17,6 +17,7 @@ OCAMLCCFLAGS+=-ccopt -D_GNU_SOURCE include ../Makefile.bundles +.NOTPARALLEL: .prepare .prepare: $(MARKER) cd $(SRC_DIR) && ./configure touch $@
bundles/pcre/Makefile +1 -0
@@ -24,6 +24,7 @@ EXTRALNKFLAGS=$(PCRE_LIBS:%=-ldopt %) include ../Makefile.bundles +.NOTPARALLEL: .prepare .prepare: $(MARKER) if [ "$$OCAMLVERSION" "<" 4.02.0 ]; then \ cp $(SRC_DIR)/pcre_compat312.ml $(SRC_DIR)/pcre_compat.ml; \
bundles/pycaml/Makefile +1 -0
@@ -17,6 +17,7 @@ export PYMAJOR=$(shell echo ${PYTHON_VERSION} | sed -e 's/\..*//') include ../Makefile.bundles +.NOTPARALLEL: .prepare .prepare: $(MARKER) rm -f "$(SRC_DIR)/pycaml.mli" $(CC) -E -w -D PYMAJOR$(PYMAJOR) -xc pycaml.pp.ml >$(SRC_DIR)/pycaml.ml
Signature · 1 line
2.7.0
PATCH v3 1/1 bundles/pycaml/: use .NOTPARALLEL on bundles
Quoted 4 lines
bundles/menhirLib/Makefile | 1 + bundles/parmap/Makefile | 1 + bundles/pcre/Makefile | 1 + bundles/pycaml/Makefile | 1 +
How do you think about to omit the key word "pycaml" from the commit subject when four software areas are affected here?
Quoted 1 line
+.NOTPARALLEL: .prepare
Would you like to leave the prerequisite specification empty?
https://www.gnu.org/software/make/manual/html_node/Special-Targets.html
Will an other design approach be better for these make scripts?
Regards,
Markus
PATCH v3 1/1 bundles/pycaml/: use .NOTPARALLEL on bundles
In reply to Luis R. RodriguezQuoted 3 lines
make[6]: *** No rule to make target 'chemoelectric-pycaml-8614105/pycaml.a', needed by 'all-opt-build-targets'.
How do you think about to complete the dependency specification because of this error message?
https://github.com/coccinelle/coccinelle/blob/b102e7684f79aa05ba7bcc7927d0382f2ab51e72/bundles/Makefile.bundles#L32
Regards,
Markus
PATCH v3 1/1 bundles/pycaml/: use .NOTPARALLEL on bundles
In reply to SF Markus ElfringQuoted 6 lines · SF Markus Elfring
Quoted 4 lines
bundles/menhirLib/Makefile | 1 + bundles/parmap/Makefile | 1 + bundles/pcre/Makefile | 1 + bundles/pycaml/Makefile | 1 +How do you think about to
[...]
I'm dropping this patch in favor of some other stuff being which will fix this in a better way.
Luis