xfs: indentation fix in xfs_btree_get_iroot()
PATCH v2 1/1 xfs: indentation fix in xfs_btree_get_iroot()
The indentation in this function is different from the other functions. Those spacebars are converted to tabs to improve readability.
---
fs/xfs/libxfs/xfs_btree.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
fs/xfs/libxfs/xfs_btree.c +0 -0
@@ -543,12 +543,12 @@ xfs_btree_ptr_addr(
*/
STATIC struct xfs_btree_block * xfs_btree_get_iroot(
- struct xfs_btree_cur *cur)
+ struct xfs_btree_cur *cur)
{
- struct xfs_ifork *ifp;
+ struct xfs_ifork *ifp;
- ifp = XFS_IFORK_PTR(cur->bc_private.b.ip, cur-
Quoted 1 line
bc_private.b.whichfork);
- return (struct xfs_btree_block *)ifp->if_broot;
+ ifp = XFS_IFORK_PTR(cur->bc_private.b.ip, cur-
Quoted 1 line
bc_private.b.whichfork);
+ return (struct xfs_btree_block *)ifp->if_broot;
}
/*
--
2.9.0
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Quoted 28 lines · Kaho Ng
The indentation in this function is different from the other functions. Those spacebars are converted to tabs to improve readability.
Signed-off-by Kaho Ng <[email protected]>---
fs/xfs/libxfs/xfs_btree.c | 8 ++++----1 file changed, 4 insertions(+), 4 deletions(-)fs/xfs/libxfs/xfs_btree.c +0
-0@@ -543,12 +543,12 @@ xfs_btree_ptr_addr(*/ STATIC struct
xfs_btree_block*
xfs_btree_get_iroot(
- struct xfs_btree_cur *cur)fs/xfs/libxfs/xfs_btree.c +1
-0+ struct xfs_btree_cur *cur){
- struct xfs_ifork *ifp;fs/xfs/libxfs/xfs_btree.c +1
-0+struct xfs_ifork *ifp;
- ifp = XFS_IFORK_PTR(cur->bc_private.b.ip, cur-Quoted 1 line
bc_private.b.whichfork);
- return (struct
xfs_btree_block*)ifp->if_broot;fs/xfs/libxfs/xfs_btree.c +1
-0+ ifp = XFS_IFORK_PTR(cur->bc_private.b.ip, cur-Quoted 1 line
bc_private.b.whichfork);
fs/xfs/libxfs/xfs_btree.c +1
-0+return (struct xfs_btree_block *)ifp->if_broot;
Quoted 1 line
}
That's better, but your mailer is still doing weird things to the patch. It line wrapped it this time, and converted all the spaces to some wierd multi-byte character instead of a plain ascii space.
What you should do is send the patch to yourself, extract it from the email you receive, and try to apply it to a clean tree. If you can do that, then the patch is not getting mangled when you send it. See Documentation/SubmittingPatches and Documentation/email-clients.txt for help.
Cheers,
Dave.
Signature · 7 lines
Dave Chinner [email protected] _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
Quoted 35 lines · Dave Chinner
Quoted 28 lines · Kaho Ng
The indentation in this function is different from the other functions. Those spacebars are converted to tabs to improve readability.
Signed-off-by Kaho Ng <[email protected]>---
fs/xfs/libxfs/xfs_btree.c | 8 ++++----1 file changed, 4 insertions(+), 4 deletions(-)fs/xfs/libxfs/xfs_btree.c +0
-0@@ -543,12 +543,12 @@ xfs_btree_ptr_addr(*/ STATIC struct
xfs_btree_block*
xfs_btree_get_iroot(
- struct xfs_btree_cur *cur)fs/xfs/libxfs/xfs_btree.c +1
-0+ struct xfs_btree_cur *cur){
- struct xfs_ifork *ifp;fs/xfs/libxfs/xfs_btree.c +1
-0+struct xfs_ifork *ifp;
- ifp = XFS_IFORK_PTR(cur->bc_private.b.ip, cur-Quoted 1 line
bc_private.b.whichfork);
- return (struct
xfs_btree_block*)ifp->if_broot;fs/xfs/libxfs/xfs_btree.c +1
-0+ ifp = XFS_IFORK_PTR(cur->bc_private.b.ip, cur-Quoted 1 line
bc_private.b.whichfork);
fs/xfs/libxfs/xfs_btree.c +1
-0+return (struct xfs_btree_block *)ifp->if_broot;Quoted 1 line
}
That's better, but your mailer is still doing weird things to the patch. It line wrapped it this time, and converted all the spaces to some wierd multi-byte character instead of a plain ascii space.
Quoted 6 lines
What you should do is send the patch to yourself, extract it from the email you receive, and try to apply it to a clean tree. If you can do that, then the patch is not getting mangled when you send it. See
Documentation/SubmittingPatchesandDocumentation/email-clients.txtfor help.
This is a problem when sending patches from a gmail account. It's converted to a base64 format, instead of pure clean text.
I'd setup git to send the patch through the gmail smtp using git send-email. So it won't screw up with the file format. Well, at least, that's what I do when I need to send patches through a gmail account :)
Signature · 6 lines
Carlos _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
Thanks for the suggestion. I am going to tidy up the things and resend it.
2016-06-22 16:23 GMT+08:00 Carlos Maiolino <[email protected]>:
Quoted 46 lines · Dave Chinner
Quoted 35 lines · Kaho Ng
Quoted 19 lines
The indentation in this function is different from the other functions. Those spacebars are converted to tabs to improve readability.
Signed-off-by Kaho Ng <[email protected]>--- fs/xfs/libxfs/xfs_btree.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)fs/xfs/libxfs/xfs_btree.c +1
-1@@ -543,12 +543,12 @@ xfs_btree_ptr_addr(*/ STATIC struct xfs_btree_block *xfs_btree_get_iroot ( -struct xfs_btree_cur *cur) +struct xfs_btree_cur *cur) {fs/xfs/libxfs/xfs_btree.c xfs_btree_ptr_addr( · line 554
Quoted 10 lines
fs/xfs/libxfs/xfs_btree.c +3
-3-struct xfs_ifork *ifp; +struct xfs_ifork *ifp; - ifp =XFS_IFORK_PTR (cur->bc_private.b.ip, cur- >bc_private.b.whichfork); -return (struct xfs_btree_block *)ifp->if_broot; + ifp =XFS_IFORK_PTR (cur->bc_private.b.ip, cur- >bc_private.b.whichfork); +return (struct xfs_btree_block *)ifp->if_broot; }That's better, but your mailer is still doing weird things to the patch. It line wrapped it this time, and converted all the spaces to some wierd multi-byte character instead of a plain ascii space.
Quoted 6 lines
What you should do is send the patch to yourself, extract it from the email you receive, and try to apply it to a clean tree. If you can do that, then the patch is not getting mangled when you send it. See
Documentation/SubmittingPatchesandDocumentation/email-clients.txtfor help.This is a problem when sending patches from a gmail account. It's converted to a base64 format, instead of pure clean text.
Quoted 6 lines
I'd setup git to send the patch through the gmail smtp using git send-email. So it won't screw up with the file format. Well, at least, that's what I do when I need to send patches through a gmail account :)
--
Carlos
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs