Skip to contentSkip to conversation

powerpc/pci: Don't try to allocate resources that will be reassigned

RFC/PATCH Benjamin Herrenschmidt 1 participant 2 messages Jun 22, 2016 – Jun 24, 2016 PowerPC

lore
Share & tools
lore
#0 lore raw

When we know we will reassign all resources, trying (and failing) to allocate them initially is fairly pointless and leads to a lot of scary messages in the kernel log

--

This one probably needs testing on a few platforms but I think it's correct ;-)

---
 arch/powerpc/kernel/pci-common.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/powerpc/kernel/pci-common.c +2 -2
index e723a32..2a67b16 100644
@@ -1360,9 +1360,9 @@ void __init pcibios_resource_survey(void)
 	struct pci_bus *b;
 
 	/* Allocate and assign resources */
+	list_for_each_entry(b, &pci_root_buses, node)
+		pcibios_allocate_bus_resources(b);
 	if (!pci_has_flag(PCI_REASSIGN_ALL_RSRC)) {
-		list_for_each_entry(b, &pci_root_buses, node)
-			pcibios_allocate_bus_resources(b);
 		pcibios_allocate_resources(0);
 		pcibios_allocate_resources(1);
 	}
#1 lore raw
Quoted 9 lines · Benjamin Herrenschmidt

When we know we will reassign all resources, trying (and failing) to allocate them initially is fairly pointless and leads to a lot of scary messages in the kernel log

--

This one probably needs testing on a few platforms but I think it's correct ;-)

The patch is crap, it was against one of my trees that has not the right code in it. I'll post the real one as v2