Skip to contentSkip to conversation

iptables: extensions: libxt_MARK: Fix translation of --set-xmark option

PATCH New [email protected] 1 participant 1 message Jun 22, 2016 netfilter

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iptables: extensions: libxt_MARK: Fix translation of --set-xmark option

From: Roberto García <[email protected]>

Fix translation of MARK target's --set-xmark option.

Before:
#iptables-translate -t mangle -A PREROUTING -j MARK --set-xmark 0x64/0xaf nft add rule ip mangle PREROUTING counter meta mark set mark xor 0x64 and 0xaf

After:

  # iptables-translate -t mangle -A PREROUTING -j MARK --set-xmark 0x64/0xaf
  nft add rule ip mangle PREROUTING counter meta mark set mark and 0xffffff50 \
  xor 0x64
---
 extensions/libxt_MARK.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
extensions/libxt_MARK.c +2 -2
index ec1ed05..bfcb030 100644
@@ -261,8 +261,8 @@ static int mark_tg_xlate(const void *ip, const struct xt_entry_target *target,
 	else if (info->mask == 0xffffffffU)
 		xt_xlate_add(xl, "0x%x ", info->mark);
 	else
-		xt_xlate_add(xl, "mark xor 0x%x and 0x%x ", info->mark,
-			     info->mask);
+		xt_xlate_add(xl, "mark and 0x%x xor 0x%x ", ~info->mask,
+			     info->mark);
 
 	return 1;
 }
Signature · 6 lines
2.8.0

--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html