Skip to contentSkip to conversation

drm/i915: intel_dp_check_link_status should only return status of link

PATCH In review Manasi Navare 5 participants 8 messages Jul 1, 2016 – Jul 11, 2016

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: intel_dp_check_link_status should only return status of link

Intel_dp_check_link_status() function reads the Link status registers and returns a boolean to indicate link is good or bad.
If the link is bad, it is retrained outside the function based on the return value.

---
 drivers/gpu/drm/i915/intel_dp.c | 41 ++++++++++++++++++++++++-----------------
 1 file changed, 24 insertions(+), 17 deletions(-)
drivers/gpu/drm/i915/intel_dp.c +24 -17
index 6d586b7..c795c9e 100644
@@ -3863,7 +3863,7 @@ go_again:
 	return -EINVAL;
 }
 
-static void
+static bool
 intel_dp_check_link_status(struct intel_dp *intel_dp)
 {
 	struct intel_encoder *intel_encoder = &dp_to_dig_port(intel_dp)->base;
@@ -3873,26 +3873,25 @@ intel_dp_check_link_status(struct intel_dp *intel_dp)
 	WARN_ON(!drm_modeset_is_locked(&dev->mode_config.connection_mutex));
 
 	if (!intel_dp_get_link_status(intel_dp, link_status)) {
-		DRM_ERROR("Failed to get link status\n");
-		return;
+		DRM_DEBUG_KMS("Failed to get link status\n");
+		return false;
 	}
 
-	if (!intel_encoder->base.crtc)
-		return;
+	/* Check if the link is valid by reading the bits of Link status
+	 * registers
+	 */
+	if (!drm_dp_channel_eq_ok(link_status, intel_dp->lane_count) ||
+	    !drm_dp_clock_recovery_ok(link_status, intel_dp->lane_count)) {
+		DRM_DEBUG_KMS("Channel EQ or CR not ok, need to retrain\n");
+		return false;
+	}
 
-	if (!to_intel_crtc(intel_encoder->base.crtc)->active)
-		return;
+	DRM_DEBUG_KMS("Link is good, no need to retrain\n");
+	return true;
 
-	/* if link training is requested we should perform it always */
-	if ((intel_dp->compliance_test_type == DP_TEST_LINK_TRAINING) ||
-	    (!drm_dp_channel_eq_ok(link_status, intel_dp->lane_count))) {
-		DRM_DEBUG_KMS("%s: channel EQ not ok, retraining\n",
-			      intel_encoder->base.name);
-		intel_dp_start_link_train(intel_dp);
-		intel_dp_stop_link_train(intel_dp);
-	}
 }
 
+
 /*
  * According to DP spec
  * 5.1.2:
@@ -3950,7 +3949,11 @@ intel_dp_short_pulse(struct intel_dp *intel_dp)
 	}
 
 	drm_modeset_lock(&dev->mode_config.connection_mutex, NULL);
-	intel_dp_check_link_status(intel_dp);
+	if (!intel_dp_check_link_status(intel_dp) ||
+	    intel_dp->compliance_test_type == DP_TEST_LINK_TRAINING) {
+		intel_dp_start_link_train(intel_dp);
+		intel_dp_stop_link_train(intel_dp);
+	}
 	drm_modeset_unlock(&dev->mode_config.connection_mutex);
 
 	return true;
@@ -4271,7 +4274,11 @@ intel_dp_long_pulse(struct intel_connector *intel_connector)
 		 * link loss triggerring long pulse!!!!
 		 */
 		drm_modeset_lock(&dev->mode_config.connection_mutex, NULL);
-		intel_dp_check_link_status(intel_dp);
+		if (!intel_dp_check_link_status(intel_dp) ||
+		    intel_dp->compliance_test_type == DP_TEST_LINK_TRAINING) {
+			intel_dp_start_link_train(intel_dp);
+			intel_dp_stop_link_train(intel_dp);
+		}
 		drm_modeset_unlock(&dev->mode_config.connection_mutex);
 		goto out;
 	}
Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw
Quoted 25 lines · Manasi Navare

Intel_dp_check_link_status() function reads the Link status registers and returns a boolean to indicate link is good or bad.
If the link is bad, it is retrained outside the function based on the return value.

---
 drivers/gpu/drm/i915/intel_dp.c | 41 ++++++++++++++++++++++++-----------------
 1 file changed, 24 insertions(+), 17 deletions(-)
drivers/gpu/drm/i915/intel_dp.c +1 -1
index 6d586b7..c795c9e 100644
@@ -3863,7 +3863,7 @@ go_again:
        return -EINVAL;
 }
 
-static void
+static bool
 intel_dp_check_link_status(struct intel_dp *intel_dp)
 {
        struct intel_encoder *intel_encoder = &dp_to_dig_port(intel_dp)->base;
@@ -3873,26 +3873,25 @@ intel_dp_check_link_status(struct intel_dp *intel_dp)
        WARN_ON(!drm_modeset_is_locked(&dev->mode_config.connection_mutex));

drivers/gpu/drm/i915/intel_dp.c intel_dp_check_link_status(struct intel_dp *intel_dp) · line 3881

Quoted 10 lines
drivers/gpu/drm/i915/intel_dp.c +2 -4
 
        if (!intel_dp_get_link_status(intel_dp, link_status)) {
-               DRM_ERROR("Failed to get link status\n");
-               return;
+               DRM_DEBUG_KMS("Failed to get link status\n");
+               return false;
        }
 
-       if (!intel_encoder->base.crtc)
-               return;

where did this check go? why don't we need this anymore?

drivers/gpu/drm/i915/intel_dp.c intel_dp_check_link_status(struct intel_dp *intel_dp) · line 3884

Quoted 11 lines
drivers/gpu/drm/i915/intel_dp.c +8 -2
+       /* Check if the link is valid by reading the bits of Link status
+        * registers
+        */
+       if (!drm_dp_channel_eq_ok(link_status, intel_dp->lane_count) ||
+           !drm_dp_clock_recovery_ok(link_status, intel_dp->lane_count)) {
+               DRM_DEBUG_KMS("Channel EQ or CR not ok, need to retrain\n");
+               return false;
+       }
 
-       if (!to_intel_crtc(intel_encoder->base.crtc)->active)
-               return;

what happens if it is not active now? are we going to attemtp the retraing in this case?
in other words: we really don't need this check anymore as the one above?

Thanks,
Rodrigo.

Quoted 50 lines
drivers/gpu/drm/i915/intel_dp.c +13 -11
+       DRM_DEBUG_KMS("Link is good, no need to retrain\n");
+       return true;
 
-       /* if link training is requested we should perform it always */
-       if ((intel_dp->compliance_test_type == DP_TEST_LINK_TRAINING) ||
-           (!drm_dp_channel_eq_ok(link_status, intel_dp->lane_count))) {
-               DRM_DEBUG_KMS("%s: channel EQ not ok, retraining\n",
-                             intel_encoder->base.name);
-               intel_dp_start_link_train(intel_dp);
-               intel_dp_stop_link_train(intel_dp);
-       }
 }
 
+
 /*
  * According to DP spec
  * 5.1.2:
@@ -3950,7 +3949,11 @@ intel_dp_short_pulse(struct intel_dp *intel_dp)
        }
 
        drm_modeset_lock(&dev->mode_config.connection_mutex, NULL);
-       intel_dp_check_link_status(intel_dp);
+       if (!intel_dp_check_link_status(intel_dp) ||
+           intel_dp->compliance_test_type == DP_TEST_LINK_TRAINING) {
+               intel_dp_start_link_train(intel_dp);
+               intel_dp_stop_link_train(intel_dp);
+       }
        drm_modeset_unlock(&dev->mode_config.connection_mutex);
 
        return true;
@@ -4271,7 +4274,11 @@ intel_dp_long_pulse(struct intel_connector *intel_connector)
                 * link loss triggerring long pulse!!!!
                 */
                drm_modeset_lock(&dev->mode_config.connection_mutex, NULL);
-               intel_dp_check_link_status(intel_dp);
+               if (!intel_dp_check_link_status(intel_dp) ||
+                   intel_dp->compliance_test_type == DP_TEST_LINK_TRAINING) {
+                       intel_dp_start_link_train(intel_dp);
+                       intel_dp_stop_link_train(intel_dp);
+               }
                drm_modeset_unlock(&dev->mode_config.connection_mutex);
                goto out;
        }
--

1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Signature · 6 lines
Rodrigo Vivi
Blog: http://blog.vivi.eng.br
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#2 lore raw
Quoted 34 lines · Rodrigo Vivi
Quoted 33 lines · Manasi Navare

Intel_dp_check_link_status() function reads the Link status registers and returns a boolean to indicate link is good or bad.
If the link is bad, it is retrained outside the function based on the return value.

---
 drivers/gpu/drm/i915/intel_dp.c | 41 ++++++++++++++++++++++++-----------------
 1 file changed, 24 insertions(+), 17 deletions(-)
drivers/gpu/drm/i915/intel_dp.c +3 -3
index 6d586b7..c795c9e 100644
@@ -3863,7 +3863,7 @@ go_again:
        return -EINVAL;
 }
 
-static void
+static bool
 intel_dp_check_link_status(struct intel_dp *intel_dp)
 {
        struct intel_encoder *intel_encoder = &dp_to_dig_port(intel_dp)->base;
@@ -3873,26 +3873,25 @@ intel_dp_check_link_status(struct intel_dp *intel_dp)
        WARN_ON(!drm_modeset_is_locked(&dev->mode_config.connection_mutex));
 
        if (!intel_dp_get_link_status(intel_dp, link_status)) {
-               DRM_ERROR("Failed to get link status\n");
-               return;
+               DRM_DEBUG_KMS("Failed to get link status\n");
+               return false;
        }
 
Quoted 5 lines

drivers/gpu/drm/i915/intel_dp.c intel_dp_check_link_status(struct intel_dp *intel_dp) · line 3881

Quoted 2 lines
drivers/gpu/drm/i915/intel_dp.c +0 -2
-       if (!intel_encoder->base.crtc)
-               return;

where did this check go? why don't we need this anymore?

This function is being refactored to handle upront link training independent of modeset and according to the spec, this function should only read the DPCD registers to check if the link is valid. In case of upfront link training, we do not care about the crtc or if the crtc is active hence this and the next check for crtc acrive are not needed.

Quoted 65 lines

drivers/gpu/drm/i915/intel_dp.c intel_dp_check_link_status(struct intel_dp *intel_dp) · line 3884

Quoted 11 lines
drivers/gpu/drm/i915/intel_dp.c +8 -2
+       /* Check if the link is valid by reading the bits of Link status
+        * registers
+        */
+       if (!drm_dp_channel_eq_ok(link_status, intel_dp->lane_count) ||
+           !drm_dp_clock_recovery_ok(link_status, intel_dp->lane_count)) {
+               DRM_DEBUG_KMS("Channel EQ or CR not ok, need to retrain\n");
+               return false;
+       }
 
-       if (!to_intel_crtc(intel_encoder->base.crtc)->active)
-               return;

what happens if it is not active now? are we going to attemtp the retraing in this case?
in other words: we really don't need this check anymore as the one above?

Thanks,
Rodrigo.

Quoted 46 lines
drivers/gpu/drm/i915/intel_dp.c +13 -11
+       DRM_DEBUG_KMS("Link is good, no need to retrain\n");
+       return true;
 
-       /* if link training is requested we should perform it always */
-       if ((intel_dp->compliance_test_type == DP_TEST_LINK_TRAINING) ||
-           (!drm_dp_channel_eq_ok(link_status, intel_dp->lane_count))) {
-               DRM_DEBUG_KMS("%s: channel EQ not ok, retraining\n",
-                             intel_encoder->base.name);
-               intel_dp_start_link_train(intel_dp);
-               intel_dp_stop_link_train(intel_dp);
-       }
 }
 
+
 /*
  * According to DP spec
  * 5.1.2:
@@ -3950,7 +3949,11 @@ intel_dp_short_pulse(struct intel_dp *intel_dp)
        }
 
        drm_modeset_lock(&dev->mode_config.connection_mutex, NULL);
-       intel_dp_check_link_status(intel_dp);
+       if (!intel_dp_check_link_status(intel_dp) ||
+           intel_dp->compliance_test_type == DP_TEST_LINK_TRAINING) {
+               intel_dp_start_link_train(intel_dp);
+               intel_dp_stop_link_train(intel_dp);
+       }
        drm_modeset_unlock(&dev->mode_config.connection_mutex);
 
        return true;
@@ -4271,7 +4274,11 @@ intel_dp_long_pulse(struct intel_connector *intel_connector)
                 * link loss triggerring long pulse!!!!
                 */
                drm_modeset_lock(&dev->mode_config.connection_mutex, NULL);
-               intel_dp_check_link_status(intel_dp);
+               if (!intel_dp_check_link_status(intel_dp) ||
+                   intel_dp->compliance_test_type == DP_TEST_LINK_TRAINING) {
+                       intel_dp_start_link_train(intel_dp);
+                       intel_dp_stop_link_train(intel_dp);
+               }
                drm_modeset_unlock(&dev->mode_config.connection_mutex);
                goto out;
        }
--

1.9.1

Quoted 10 lines
Quoted 4 lines

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Signature · 2 lines
Rodrigo Vivi
Blog: http://blog.vivi.eng.br

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw

✗ Ro.CI.BAT: failure for drm/i915: intel_dp_check_link_status should only return status of link

In reply to Manasi Navare
== Series Details ==

== Series Details ==

Series: drm/i915: intel_dp_check_link_status should only return status of link
URL : https://patchwork.freedesktop.org/series/9400/
State : failure

== Summary ==

Series 9400v1 drm/i915: intel_dp_check_link_status should only return status of link
http://patchwork.freedesktop.org/api/1.0/series/9400/revisions/1/mbox

Test drv_module_reload_basic:

                pass       -> DMESG-WARN (ro-bdw-i7-5600u)
                pass       -> INCOMPLETE (ro-bdw-i7-5557U)
                pass       -> SKIP       (fi-skl-i5-6260u)
Test gem_exec_flush:
        Subgroup basic-batch-kernel-default-uc:
                pass       -> DMESG-FAIL (ro-skl3-i5-6260u)
                pass       -> DMESG-FAIL (fi-skl-i5-6260u)
                pass       -> DMESG-FAIL (fi-skl-i7-6700k)
        Subgroup basic-batch-kernel-default-wb:
                dmesg-fail -> PASS       (fi-skl-i5-6260u)
Test gem_exec_suspend:
        Subgroup basic-s3:
                incomplete -> PASS       (fi-hsw-i7-4770k)
Test gem_storedw_loop:
        Subgroup basic-default:
                pass       -> INCOMPLETE (ro-bdw-i5-5250u)
fi-hsw-i7-4770k  total:231  pass:196  dwarn:0   dfail:0   fail:2   skip:33 
fi-skl-i5-6260u  total:231  pass:202  dwarn:0   dfail:3   fail:0   skip:26 
fi-skl-i7-6700k  total:231  pass:189  dwarn:0   dfail:3   fail:0   skip:39 
fi-snb-i7-2600   total:231  pass:176  dwarn:0   dfail:0   fail:2   skip:53 
ro-bdw-i5-5250u  total:10   pass:9    dwarn:0   dfail:0   fail:0   skip:0  
ro-bdw-i7-5557U  total:26   pass:20   dwarn:0   dfail:0   fail:0   skip:5  
ro-bdw-i7-5600u  total:229  pass:189  dwarn:1   dfail:1   fail:0   skip:38 
ro-bsw-n3050     total:229  pass:176  dwarn:1   dfail:1   fail:2   skip:49 
ro-byt-n2820     total:229  pass:180  dwarn:0   dfail:1   fail:3   skip:45 
ro-hsw-i3-4010u  total:229  pass:197  dwarn:0   dfail:1   fail:0   skip:31 
ro-hsw-i7-4770r  total:229  pass:197  dwarn:0   dfail:1   fail:0   skip:31 
ro-ilk-i7-620lm  total:229  pass:157  dwarn:0   dfail:1   fail:1   skip:70 
ro-ilk1-i5-650   total:224  pass:157  dwarn:0   dfail:1   fail:1   skip:65 
ro-ivb-i7-3770   total:229  pass:188  dwarn:0   dfail:1   fail:0   skip:40 
ro-skl3-i5-6260u total:229  pass:207  dwarn:1   dfail:2   fail:0   skip:19 
ro-snb-i7-2620M  total:229  pass:179  dwarn:0   dfail:1   fail:1   skip:48 

fi-kbl-qkkr failed to connect after reboot

Results at /archive/results/CI_IGT_test/RO_Patchwork_1369/

8707e23 drm-intel-nightly: 2016y-07m-01d-20h-18m-16s UTC integration manifest fbe3b82 drm/i915: intel_dp_check_link_status should only return status of link

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw
In reply to Manasi Navare
reproduce:

Hi,

[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on v4.7-rc5 next-20160701]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Manasi-Navare/drm-i915-intel_dp_check_link_status-should-only-return-status-of-link/20160702-124153
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-randconfig-i0-201626 (attached as .config)
compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

drivers/gpu/drm/i915/intel_dp.c: In function 'intel_dp_check_link_status':

>> drivers/gpu/drm/i915/intel_dp.c:3872:24: error: unused variable 'intel_encoder' [-Werror=unused-variable]
     struct intel_encoder *intel_encoder = &dp_to_dig_port(intel_dp)->base;
                           ^~~~~~~~~~~~~

cc1: all warnings being treated as errors

vim +/intel_encoder +3872 drivers/gpu/drm/i915/intel_dp.c

0e32b39c Dave Airlie           2014-05-02  3866  	return -EINVAL;
0e32b39c Dave Airlie           2014-05-02  3867  }
0e32b39c Dave Airlie           2014-05-02  3868  
84fa171b Manasi Navare         2016-07-01  3869  static bool
5c9114d0 Shubhangi Shrivastava 2016-03-30  3870  intel_dp_check_link_status(struct intel_dp *intel_dp)
5c9114d0 Shubhangi Shrivastava 2016-03-30  3871  {
5c9114d0 Shubhangi Shrivastava 2016-03-30 @3872  	struct intel_encoder *intel_encoder = &dp_to_dig_port(intel_dp)->base;
5c9114d0 Shubhangi Shrivastava 2016-03-30  3873  	struct drm_device *dev = intel_dp_to_dev(intel_dp);
5c9114d0 Shubhangi Shrivastava 2016-03-30  3874  	u8 link_status[DP_LINK_STATUS_SIZE];

5c9114d0 Shubhangi Shrivastava 2016-03-30 3875

:::::: The code at line 3872 was first introduced by commit
:::::: 5c9114d0ced2f16d1bfeda650b4acf95159f4759 drm/i915: Reorganizing intel_dp_check_link_status

:::::: TO: Shubhangi Shrivastava <[email protected]> :::::: CC: Ander Conselvan de Oliveira <[email protected]>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw
In reply to Manasi Navare
reproduce:

Hi,

[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on v4.7-rc5 next-20160701]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Manasi-Navare/drm-i915-intel_dp_check_link_status-should-only-return-status-of-link/20160702-124153
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-rhel (attached as .config)
compiler: gcc-4.9 (Debian 4.9.3-14) 4.9.3
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

drivers/gpu/drm/i915/intel_dp.c: In function 'intel_dp_check_link_status':

>> drivers/gpu/drm/i915/intel_dp.c:3872:24: warning: unused variable 'intel_encoder' [-Wunused-variable]
     struct intel_encoder *intel_encoder = &dp_to_dig_port(intel_dp)->base;
                           ^

vim +/intel_encoder +3872 drivers/gpu/drm/i915/intel_dp.c

0e32b39c Dave Airlie           2014-05-02  3856  			return ret;
0e32b39c Dave Airlie           2014-05-02  3857  		} else {
0e32b39c Dave Airlie           2014-05-02  3858  			struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp);
0e32b39c Dave Airlie           2014-05-02  3859  			DRM_DEBUG_KMS("failed to get ESI - device may have failed\n");
0e32b39c Dave Airlie           2014-05-02  3860  			intel_dp->is_mst = false;
0e32b39c Dave Airlie           2014-05-02  3861  			drm_dp_mst_topology_mgr_set_mst(&intel_dp->mst_mgr, intel_dp->is_mst);
0e32b39c Dave Airlie           2014-05-02  3862  			/* send a hotplug event */
0e32b39c Dave Airlie           2014-05-02  3863  			drm_kms_helper_hotplug_event(intel_dig_port->base.base.dev);
0e32b39c Dave Airlie           2014-05-02  3864  		}
0e32b39c Dave Airlie           2014-05-02  3865  	}
0e32b39c Dave Airlie           2014-05-02  3866  	return -EINVAL;
0e32b39c Dave Airlie           2014-05-02  3867  }
0e32b39c Dave Airlie           2014-05-02  3868  
84fa171b Manasi Navare         2016-07-01  3869  static bool
5c9114d0 Shubhangi Shrivastava 2016-03-30  3870  intel_dp_check_link_status(struct intel_dp *intel_dp)
5c9114d0 Shubhangi Shrivastava 2016-03-30  3871  {
5c9114d0 Shubhangi Shrivastava 2016-03-30 @3872  	struct intel_encoder *intel_encoder = &dp_to_dig_port(intel_dp)->base;
5c9114d0 Shubhangi Shrivastava 2016-03-30  3873  	struct drm_device *dev = intel_dp_to_dev(intel_dp);
5c9114d0 Shubhangi Shrivastava 2016-03-30  3874  	u8 link_status[DP_LINK_STATUS_SIZE];
5c9114d0 Shubhangi Shrivastava 2016-03-30  3875  
5c9114d0 Shubhangi Shrivastava 2016-03-30  3876  	WARN_ON(!drm_modeset_is_locked(&dev->mode_config.connection_mutex));
5c9114d0 Shubhangi Shrivastava 2016-03-30  3877  
5c9114d0 Shubhangi Shrivastava 2016-03-30  3878  	if (!intel_dp_get_link_status(intel_dp, link_status)) {
84fa171b Manasi Navare         2016-07-01  3879  		DRM_DEBUG_KMS("Failed to get link status\n");
84fa171b Manasi Navare         2016-07-01  3880  		return false;

:::::: The code at line 3872 was first introduced by commit
:::::: 5c9114d0ced2f16d1bfeda650b4acf95159f4759 drm/i915: Reorganizing intel_dp_check_link_status

:::::: TO: Shubhangi Shrivastava <[email protected]> :::::: CC: Ander Conselvan de Oliveira <[email protected]>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#6 lore raw
In reply to Manasi Navare
Quoted 15 lines · Manasi Navare

Intel_dp_check_link_status() function reads the Link status registers and returns a boolean to indicate link is good or bad.
If the link is bad, it is retrained outside the function based on the return value.

---
 drivers/gpu/drm/i915/intel_dp.c | 41 ++++++++++++++++++++++++-----------------
 1 file changed, 24 insertions(+), 17 deletions(-)
drivers/gpu/drm/i915/intel_dp.c +0 -0
index 6d586b7..c795c9e 100644

drivers/gpu/drm/i915/intel_dp.c go_again: · line 3868

Quoted 7 lines
drivers/gpu/drm/i915/intel_dp.c +1 -1
@@ -3863,7 +3863,7 @@ go_again:
 	return -EINVAL;
 }
 
-static void
+static bool
 intel_dp_check_link_status(struct intel_dp *intel_dp)
 {

A common pattern is to name bool functions like a yes/no question, so you might want to adjust the name to something like intel_dp_link_status_ok() or intel_dp_link_is_good() here.

Best regards,

Lukas
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#7 lore raw
Quoted 28 lines · Lukas Wunner
Quoted 15 lines · Manasi Navare

Intel_dp_check_link_status() function reads the Link status registers and returns a boolean to indicate link is good or bad.
If the link is bad, it is retrained outside the function based on the return value.

---
 drivers/gpu/drm/i915/intel_dp.c | 41 ++++++++++++++++++++++++-----------------
 1 file changed, 24 insertions(+), 17 deletions(-)
drivers/gpu/drm/i915/intel_dp.c +0 -0
index 6d586b7..c795c9e 100644

drivers/gpu/drm/i915/intel_dp.c go_again: · line 3868

Quoted 7 lines
drivers/gpu/drm/i915/intel_dp.c +1 -1
@@ -3863,7 +3863,7 @@ go_again:
 	return -EINVAL;
 }
 
-static void
+static bool
 intel_dp_check_link_status(struct intel_dp *intel_dp)
 {

A common pattern is to name bool functions like a yes/no question, so you might want to adjust the name to something like intel_dp_link_status_ok() or intel_dp_link_is_good() here.

Quoted 3 lines

Best regards,

Lukas

I will change the name to follow this naming pattern.

Regards
Manasi
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx