Skip to contentSkip to conversation

Patch "crypto: user - re-add size check for CRYPTO_MSG_GETALG" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Jul 6, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

crypto: user - re-add size check for CRYPTO_MSG_GETALG

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
crypto-user-re-add-size-check-for-crypto_msg_getalg.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 055ddaace03580455a7b7dbea8e93d62acee61fc Mon Sep 17 00:00:00 2001

From: Mathias Krause <[email protected]>
Date: Wed, 22 Jun 2016 20:29:37 +0200
Subject: crypto: user - re-add size check for CRYPTO_MSG_GETALG

From: Mathias Krause <[email protected]>

commit 055ddaace03580455a7b7dbea8e93d62acee61fc upstream.

Commit 9aa867e46565 ("crypto: user - Add CRYPTO_MSG_DELRNG") accidentally removed the minimum size check for CRYPTO_MSG_GETALG netlink messages. This allows userland to send a truncated CRYPTO_MSG_GETALG message as short as a netlink header only making crypto_report() operate on uninitialized memory by accessing data beyond the end of the netlink message.

Fix this be re-adding the minimum required size of CRYPTO_MSG_GETALG messages to the crypto_msg_min[] array.

Fixes 9aa867e46565 ("crypto: user - Add CRYPTO_MSG_DELRNG")
Cc Steffen Klassert <[email protected]>
---
 crypto/crypto_user.c |    1 +
 1 file changed, 1 insertion(+)
crypto/crypto_user.c +1 -0
@@ -455,6 +455,7 @@ static const int crypto_msg_min[CRYPTO_N
 	[CRYPTO_MSG_NEWALG	- CRYPTO_MSG_BASE] = MSGSIZE(crypto_user_alg),
 	[CRYPTO_MSG_DELALG	- CRYPTO_MSG_BASE] = MSGSIZE(crypto_user_alg),
 	[CRYPTO_MSG_UPDATEALG	- CRYPTO_MSG_BASE] = MSGSIZE(crypto_user_alg),
+	[CRYPTO_MSG_GETALG	- CRYPTO_MSG_BASE] = MSGSIZE(crypto_user_alg),
 	[CRYPTO_MSG_DELRNG	- CRYPTO_MSG_BASE] = 0,
 };
 

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/crypto-user-re-add-size-check-for-crypto_msg_getalg.patch