Skip to contentSkip to conversation

Patch "USB: uas: Fix slave queue_depth not being set" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Jul 7, 2016

Subsystems (4)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

USB: uas: Fix slave queue_depth not being set

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
usb-uas-fix-slave-queue_depth-not-being-set.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 593224ea77b1ca842f45cf76f4deeef44dfbacd1 Mon Sep 17 00:00:00 2001

From: Hans de Goede <[email protected]>
Date: Tue, 31 May 2016 09:18:03 +0200
Subject: USB: uas: Fix slave queue_depth not being set

From: Hans de Goede <[email protected]>

commit 593224ea77b1ca842f45cf76f4deeef44dfbacd1 upstream.

Commit 198de51dbc34 ("USB: uas: Limit qdepth at the scsi-host level") removed the scsi_change_queue_depth() call from uas_slave_configure() assuming that the slave would inherit the host's queue_depth, which that commit sets to the same value.

This is incorrect, without the scsi_change_queue_depth() call the slave's queue_depth defaults to 1, introducing a performance regression.

This commit restores the call, fixing the performance regression.

Fixes 198de51dbc34 ("USB: uas: Limit qdepth at the scsi-host level")
---
 drivers/usb/storage/uas.c |    1 +
 1 file changed, 1 insertion(+)
drivers/usb/storage/uas.c +1 -0
@@ -811,6 +811,7 @@ static int uas_slave_configure(struct sc
 	if (devinfo->flags & US_FL_BROKEN_FUA)
 		sdev->broken_fua = 1;
 
+	scsi_change_queue_depth(sdev, devinfo->qdepth - 2);
 	return 0;
 }
 

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/usb-quirks-add-no-lpm-quirk-for-acer-c120-led-projector.patch queue-4.4/usb-quirks-fix-sorting.patch queue-4.4/usb-xhci-add-broken-streams-quirk-for-frescologic-device-id-1009.patch queue-4.4/usb-uas-fix-slave-queue_depth-not-being-set.patch