Patch "usb: host: ehci-tegra: Grab the correct UTMI pads reset" has been added to the 4.6-stable tree
Subsystems (4)
This is a note to let you know that I've just added the patch titled
usb: host: ehci-tegra: Grab the correct UTMI pads reset
to the 4.6-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
usb-host-ehci-tegra-grab-the-correct-utmi-pads-reset.patch
and it can be found in the queue-4.6 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
f8a15a9650694feaa0dabf197b0c94d37cd3fb42Mon Sep 17 00:00:00 2001
From: Thierry Reding <[email protected]>
Date: Thu, 26 May 2016 17:23:29 +0200
Subject: usb: host: ehci-tegra: Grab the correct UTMI pads reset
From: Thierry Reding <[email protected]>
commit f8a15a9650694feaa0dabf197b0c94d37cd3fb42 upstream.
There are three EHCI controllers on Tegra SoCs, each with its own reset line. However, the first controller contains a set of UTMI configuration registers that are shared with its siblings. These registers will only be reset as part of the first controller's reset. For proper operation it must be ensured that the UTMI configuration registers are reset before any of the EHCI controllers are enabled, irrespective of the probe order.
Commit a47cc24cd1e5 ("USB: EHCI: tegra: Fix probe order issue leading to broken USB") introduced code that ensures the first controller is always reset before setting up any of the controllers, and is never again reset afterwards.
This code, however, grabs the wrong reset. Each EHCI controller has two reset controls attached: 1) the USB controller reset and 2) the UTMI pads reset (really the first controller's reset). In order to reset the UTMI pads registers the code must grab the second reset, but instead it grabbing the first.
--- drivers/usb/host/ehci-tegra.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/host/ehci-tegra.c +1 -1
@@ -89,7 +89,7 @@ static int tegra_reset_usb_controller(stif (!usb1_reset_attempted) {struct reset_control *usb1_reset; - usb1_reset =of_reset_control_get (phy_np,"usb" ); + usb1_reset =of_reset_control_get (phy_np,"utmi-pads" );if (IS_ERR (usb1_reset)) {dev_warn (&pdev->dev,"can't get utmi-pads reset from the PHY\n" );
Patches currently in stable-queue which might be from [email protected] are
queue-4.6/usb-host-ehci-tegra-grab-the-correct-utmi-pads-reset.patch