Skip to contentSkip to conversation

Patch "mnt: If fs_fully_visible fails call put_filesystem." has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Jul 11, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

mnt: If fs_fully_visible fails call put_filesystem.

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
mnt-if-fs_fully_visible-fails-call-put_filesystem.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 97c1df3e54e811aed484a036a798b4b25d002ecf Mon Sep 17 00:00:00 2001

From: "Eric W. Biederman" <[email protected]>
Date: Mon, 6 Jun 2016 15:36:07 -0500
Subject: mnt: If fs_fully_visible fails call put_filesystem.

From: Eric W. Biederman <[email protected]>

commit 97c1df3e54e811aed484a036a798b4b25d002ecf upstream.

Add this trivial missing error handling.

Fixes 1b852bceb0d1 ("mnt: Refactor the logic for mounting sysfs and proc in a user namespace")
---
 fs/namespace.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
fs/namespace.c +3 -1
@@ -2401,8 +2401,10 @@ static int do_new_mount(struct path *pat
 			mnt_flags |= MNT_NODEV | MNT_LOCK_NODEV;
 		}
 		if (type->fs_flags & FS_USERNS_VISIBLE) {
-			if (!fs_fully_visible(type, &mnt_flags))
+			if (!fs_fully_visible(type, &mnt_flags)) {
+				put_filesystem(type);
 				return -EPERM;
+			}
 		}
 	}
 

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/mnt-fs_fully_visible-test-the-proper-mount-for-mnt_locked.patch queue-4.4/mnt-if-fs_fully_visible-fails-call-put_filesystem.patch queue-4.4/mnt-account-for-ms_rdonly-in-fs_fully_visible.patch