Patch "IB/core: Fix bit curruption in ib_device_cap_flags structure" has been added to the 4.6-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
IB/core: Fix bit curruption in ib_device_cap_flags structure
to the 4.6-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
ib-core-fix-bit-curruption-in-ib_device_cap_flags-structure.patch
and it can be found in the queue-4.6 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
47355b3cd7d3c9c5226bff7c449b9d269fb17fa6Mon Sep 17 00:00:00 2001
From: Max Gurtovoy <[email protected]>
Date: Mon, 6 Jun 2016 19:34:39 +0300
Subject: IB/core: Fix bit curruption in ib_device_cap_flags structure
From: Max Gurtovoy <[email protected]>
commit 47355b3cd7d3c9c5226bff7c449b9d269fb17fa6 upstream.
ib_device_cap_flags 64-bit expansion caused caps overlapping and made consumers read wrong device capabilities. For example IB_DEVICE_SG_GAPS_REG was falsely read by the iser driver causing it to use a non-existing capability. This happened because signed int becomes sign extended when converted it to u64. Fix this by casting IB_DEVICE_ON_DEMAND_PAGING enumeration to ULL.
--- include/rdma/ib_verbs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/rdma/ib_verbs.h +1 -1
@@ -217,7 +217,7 @@ enum ib_device_cap_flags {IB_DEVICE_CROSS_CHANNEL = (1 <<27 ),IB_DEVICE_MANAGED_FLOW_STEERING = (1 <<29 ),IB_DEVICE_SIGNATURE_HANDOVER = (1 <<30 ), -IB_DEVICE_ON_DEMAND_PAGING = (1 <<31 ), +IB_DEVICE_ON_DEMAND_PAGING = (1ULL <<31 ),IB_DEVICE_SG_GAPS_REG = (1ULL <<32 ), IB_DEVICE_VIRTUAL_FUNCTION = ((u64)1 << 33), };
Patches currently in stable-queue which might be from [email protected] are
queue-4.6/ib-core-fix-bit-curruption-in-ib_device_cap_flags-structure.patch