Patch "IB/rdmavt: Correct qp_priv_alloc() return value test" has been added to the 4.6-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
IB/rdmavt: Correct qp_priv_alloc() return value test
to the 4.6-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
ib-rdmavt-correct-qp_priv_alloc-return-value-test.patch
and it can be found in the queue-4.6 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
c755f4afa66ad3ed98870bd3254f37c47fb2c800Mon Sep 17 00:00:00 2001
From: Mike Marciniszyn <[email protected]>
Date: Wed, 22 Jun 2016 13:29:33 -0700
Subject: IB/rdmavt: Correct qp_priv_alloc() return value test
From: Mike Marciniszyn <[email protected]>
commit c755f4afa66ad3ed98870bd3254f37c47fb2c800 upstream.
The current drivers return errors from this calldown wrapped in an ERR_PTR().
The rdmavt code incorrectly tests for NULL.
The code is fixed to use IS_ERR() and change ret according to the driver return value.
--- drivers/infiniband/sw/rdmavt/qp.c | 4 +++- include/rdma/rdma_vt.h | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-)
drivers/infiniband/sw/rdmavt/qp.c +3 -1
@@ -683,8 +683,10 @@ struct ib_qp *rvt_create_qp(struct ib_pd* initialization that is needed. */ priv = rdi->driver_f.qp_priv_alloc (rdi, qp, gfp); -if (!priv) +if (IS_ERR (priv)) { + ret = priv; goto bail_qp; + } qp->priv = priv; qp->timeout_jiffies = usecs_to_jiffies((4096UL * (1UL << qp->timeout)) /
include/rdma/rdma_vt.h +3 -1
@@ -203,7 +203,9 @@ struct rvt_driver_provided {/* * Allocate a private queue pair data structure for driver specific -* information which is opaque to rdmavt. +* information which is opaque to rdmavt. Errors are returned via +* ERR_PTR(err). The driver is free to return NULL or a valid +* pointer. */ void * (*qp_priv_alloc)(struct rvt_dev_info *rdi,struct rvt_qp *qp,gfp_t gfp);
Patches currently in stable-queue which might be from [email protected] are
queue-4.6/ib-rdmavt-correct-qp_priv_alloc-return-value-test.patch