Skip to contentSkip to conversation

Patch "of: fix autoloading due to broken modalias with no 'compatible'" has been added to the 4.6-stable tree

PATCH [email protected] 1 participant 1 message Jul 11, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

of: fix autoloading due to broken modalias with no 'compatible'

to the 4.6-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
of-fix-autoloading-due-to-broken-modalias-with-no-compatible.patch
and it can be found in the queue-4.6 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From b3c0a4dab7e35a9b6d69c0415641d2280fdefb2b Mon Sep 17 00:00:00 2001

From: Wolfram Sang <[email protected]>
Date: Mon, 6 Jun 2016 18:48:38 +0200
Subject: of: fix autoloading due to broken modalias with no 'compatible'

From: Wolfram Sang <[email protected]>

commit b3c0a4dab7e35a9b6d69c0415641d2280fdefb2b upstream.

Because of an improper dereference, a stray 'C' character was output to the modalias when no 'compatible' was specified. This is the case for some old PowerMac drivers which only set the 'name' property. Fix it to let them match again.

Cc Philipp Zabel <[email protected]>
Cc Andreas Schwab <[email protected]>
Fixes 6543becf26fff6 ("mod/file2alias: make modalias generation safe for cross compiling")
---
 scripts/mod/file2alias.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/mod/file2alias.c +1 -1
@@ -384,7 +384,7 @@ static void do_of_entry_multi(void *symv
 	len = sprintf(alias, "of:N%sT%s", (*name)[0] ? *name : "*",
 		      (*type)[0] ? *type : "*");
 
-	if (compatible[0])
+	if ((*compatible)[0])
 		sprintf(&alias[len], "%sC%s", (*type)[0] ? "*" : "",
 			*compatible);
 

Patches currently in stable-queue which might be from [email protected] are

queue-4.6/of-fix-autoloading-due-to-broken-modalias-with-no-compatible.patch