Skip to contentSkip to conversation

drm/i915: Return -EPROBE_DEFER if we cannot get GPIO or PWM in dsi_init

PATCH In review Shobhit Kumar 4 participants 5 messages Jul 15, 2016 – Jul 16, 2016

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: Return -EPROBE_DEFER if we cannot get GPIO or PWM in dsi_init

On devices that have MIPI DSI panel control and PWM control comming from CRC PMIC, we need the gpio and pwm exported from the intel_soc_pmic driver. Defer probing for later in case we fail to get these devices.

v2: Rebased on latest drm-intel-nightly
Added failure check for pwm_get which got missed out

---
 drivers/gpu/drm/i915/i915_drv.c      |  4 ++++
 drivers/gpu/drm/i915/i915_drv.h      |  2 +-
 drivers/gpu/drm/i915/intel_display.c | 25 +++++++++++++++++++------
 drivers/gpu/drm/i915/intel_drv.h     |  2 +-
 drivers/gpu/drm/i915/intel_dsi.c     | 24 +++++++++++++++++-------
 5 files changed, 42 insertions(+), 15 deletions(-)
drivers/gpu/drm/i915/i915_drv.c +4 -0
index b9a8117..9bfe0c8 100644
@@ -648,6 +648,9 @@ static int i915_load_modeset_init(struct drm_device *dev)
 	/* Important: The output setup functions called by modeset_init need
 	 * working irqs for e.g. gmbus and dp aux transfers. */
 	intel_modeset_init(dev);
+	ret = intel_modeset_init(dev);
+	if (ret == -EPROBE_DEFER)
+		goto cleanup_deffered_probe;
 
 	intel_guc_init(dev);
 
@@ -675,6 +678,7 @@ cleanup_gem:
 	i915_gem_fini(dev);
 cleanup_irq:
 	intel_guc_fini(dev);
+cleanup_deffered_probe:
 	drm_irq_uninstall(dev);
 	intel_teardown_gmbus(dev);
 cleanup_csr:
drivers/gpu/drm/i915/i915_drv.h +1 -1
index 03e1bfa..a9eed22 100644
@@ -3778,7 +3778,7 @@ void intel_device_info_dump(struct drm_i915_private *dev_priv);
 
 /* modesetting */
 extern void intel_modeset_init_hw(struct drm_device *dev);
-extern void intel_modeset_init(struct drm_device *dev);
+extern int intel_modeset_init(struct drm_device *dev);
 extern void intel_modeset_gem_init(struct drm_device *dev);
 extern void intel_modeset_cleanup(struct drm_device *dev);
 extern int intel_connector_register(struct drm_connector *);
drivers/gpu/drm/i915/intel_display.c +19 -6
index be3b2ca..b1250f2 100644
@@ -14612,11 +14612,12 @@ static bool intel_crt_present(struct drm_device *dev)
 	return true;
 }
 
-static void intel_setup_outputs(struct drm_device *dev)
+static int intel_setup_outputs(struct drm_device *dev)
 {
 	struct drm_i915_private *dev_priv = to_i915(dev);
 	struct intel_encoder *encoder;
 	bool dpd_is_edp = false;
+	int ret = 0;
 
 	/*
 	 * intel_edp_init_connector() depends on this completing first, to
@@ -14638,7 +14639,9 @@ static void intel_setup_outputs(struct drm_device *dev)
 		intel_ddi_init(dev, PORT_B);
 		intel_ddi_init(dev, PORT_C);
 
-		intel_dsi_init(dev);
+		ret = intel_dsi_init(dev);
+		if (ret == -EPROBE_DEFER)
+			return ret;
 	} else if (HAS_DDI(dev)) {
 		int found;
 
@@ -14742,7 +14745,9 @@ static void intel_setup_outputs(struct drm_device *dev)
 				intel_hdmi_init(dev, CHV_HDMID, PORT_D);
 		}
 
-		intel_dsi_init(dev);
+		ret = intel_dsi_init(dev);
+		if (ret == -EPROBE_DEFER)
+			return ret;
 	} else if (!IS_GEN2(dev) && !IS_PINEVIEW(dev)) {
 		bool found = false;
 
@@ -14795,6 +14800,8 @@ static void intel_setup_outputs(struct drm_device *dev)
 	intel_init_pch_refclk(dev);
 
 	drm_helper_move_panel_connectors_to_head(dev);
+
+	return 0;
 }
 
 static void intel_user_framebuffer_destroy(struct drm_framebuffer *fb)
@@ -15539,7 +15546,7 @@ fail:
 	drm_modeset_acquire_fini(&ctx);
 }
 
-void intel_modeset_init(struct drm_device *dev)
+int intel_modeset_init(struct drm_device *dev)
 {
 	struct drm_i915_private *dev_priv = to_i915(dev);
 	struct i915_ggtt *ggtt = &dev_priv->ggtt;
@@ -15564,7 +15571,7 @@ void intel_modeset_init(struct drm_device *dev)
 	intel_init_pm(dev);
 
 	if (INTEL_INFO(dev)->num_pipes == 0)
-		return;
+		return 0;
 
 	/*
 	 * There may be no VBT; and if the BIOS enabled SSC we can
@@ -15632,7 +15639,11 @@ void intel_modeset_init(struct drm_device *dev)
 
 	/* Just disable it once at startup */
 	i915_disable_vga(dev);
-	intel_setup_outputs(dev);
+
+	/* Check if we encountered -EPROBE_DEFER while initializing DSI */
+	ret = intel_setup_outputs(dev);
+	if (ret)
+		return ret;
 
 	drm_modeset_lock_all(dev);
 	intel_modeset_setup_hw_state(dev);
@@ -15667,6 +15678,8 @@ void intel_modeset_init(struct drm_device *dev)
 	 * since the watermark calculation done here will use pstate->fb.
 	 */
 	sanitize_watermarks(dev);
+
+	return 0;
 }
 
 static void intel_enable_pipe_a(struct drm_device *dev)
drivers/gpu/drm/i915/intel_drv.h +1 -1
index 55aeaf0..4f05b7c 100644
@@ -1418,7 +1418,7 @@ int intel_dp_aux_init_backlight_funcs(struct intel_connector *intel_connector);
 int intel_dp_mst_encoder_init(struct intel_digital_port *intel_dig_port, int conn_id);
 void intel_dp_mst_encoder_cleanup(struct intel_digital_port *intel_dig_port);
 /* intel_dsi.c */
-void intel_dsi_init(struct drm_device *dev);
+int intel_dsi_init(struct drm_device *dev);
 
 /* intel_dsi_dcs_backlight.c */
 int intel_dsi_dcs_init_backlight_funcs(struct intel_connector *intel_connector);
drivers/gpu/drm/i915/intel_dsi.c +17 -7
index de8e9fb..5c02a3f 100644
@@ -1422,7 +1422,7 @@ static void intel_dsi_add_properties(struct intel_connector *connector)
 	}
 }
 
-void intel_dsi_init(struct drm_device *dev)
+int intel_dsi_init(struct drm_device *dev)
 {
 	struct intel_dsi *intel_dsi;
 	struct intel_encoder *intel_encoder;
@@ -1433,12 +1433,13 @@ void intel_dsi_init(struct drm_device *dev)
 	struct drm_i915_private *dev_priv = to_i915(dev);
 	enum port port;
 	unsigned int i;
+	int ret = 0;
 
 	DRM_DEBUG_KMS("\n");
 
 	/* There is no detection method for MIPI so rely on VBT */
 	if (!intel_bios_is_dsi_present(dev_priv, &port))
-		return;
+		return 0;
 
 	if (IS_VALLEYVIEW(dev) || IS_CHERRYVIEW(dev)) {
 		dev_priv->mipi_mmio_base = VLV_MIPI_BASE;
@@ -1446,17 +1447,17 @@ void intel_dsi_init(struct drm_device *dev)
 		dev_priv->mipi_mmio_base = BXT_MIPI_BASE;
 	} else {
 		DRM_ERROR("Unsupported Mipi device to reg base");
-		return;
+		return 0;
 	}
 
 	intel_dsi = kzalloc(sizeof(*intel_dsi), GFP_KERNEL);
 	if (!intel_dsi)
-		return;
+		return -ENOMEM;
 
 	intel_connector = intel_connector_alloc();
 	if (!intel_connector) {
 		kfree(intel_dsi);
-		return;
+		return -ENOMEM;
 	}
 
 	intel_encoder = &intel_dsi->base;
@@ -1560,6 +1561,9 @@ void intel_dsi_init(struct drm_device *dev)
 		if (IS_ERR(intel_dsi->gpio_panel)) {
 			DRM_ERROR("Failed to own gpio for panel control\n");
 			intel_dsi->gpio_panel = NULL;
+
+			ret = -EPROBE_DEFER;
+			goto err;
 		}
 	}
 
@@ -1597,14 +1601,20 @@ void intel_dsi_init(struct drm_device *dev)
 	connector->display_info.height_mm = fixed_mode->height_mm;
 
 	intel_panel_init(&intel_connector->panel, fixed_mode, NULL);
-	intel_panel_setup_backlight(connector, INVALID_PIPE);
+	ret = intel_panel_setup_backlight(connector, INVALID_PIPE);
+	if (ret == -ENODEV) {
+		ret = -EPROBE_DEFER;
+		goto err;
+	}
 
 	intel_dsi_add_properties(intel_connector);
 
-	return;
+	return 0;
 
 err:
 	drm_encoder_cleanup(&intel_encoder->base);
 	kfree(intel_dsi);
 	kfree(intel_connector);
+
+	return ret;
 }
Signature · 6 lines
2.5.5

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw
Quoted 7 lines · Shobhit Kumar

On devices that have MIPI DSI panel control and PWM control comming from CRC PMIC, we need the gpio and pwm exported from the intel_soc_pmic driver. Defer probing for later in case we fail to get these devices.

v2: Rebased on latest drm-intel-nightly
Added failure check for pwm_get which got missed out

Just an attempt and is untested yet because of lack of device which use CRC PMIC or LPSS. Hopefully can get some testing help from Stephen and Viric who have such devices.

Regards
Shobhit

Quoted 231 lines
---
 drivers/gpu/drm/i915/i915_drv.c      |  4 ++++
 drivers/gpu/drm/i915/i915_drv.h      |  2 +-
 drivers/gpu/drm/i915/intel_display.c | 25 +++++++++++++++++++------
 drivers/gpu/drm/i915/intel_drv.h     |  2 +-
 drivers/gpu/drm/i915/intel_dsi.c     | 24 +++++++++++++++++-------
 5 files changed, 42 insertions(+), 15 deletions(-)
drivers/gpu/drm/i915/i915_drv.c +4 -0
index b9a8117..9bfe0c8 100644
@@ -648,6 +648,9 @@ static int i915_load_modeset_init(struct drm_device *dev)
        /* Important: The output setup functions called by modeset_init need
         * working irqs for e.g. gmbus and dp aux transfers. */
        intel_modeset_init(dev);
+       ret = intel_modeset_init(dev);
+       if (ret == -EPROBE_DEFER)
+               goto cleanup_deffered_probe;
 
        intel_guc_init(dev);
 
@@ -675,6 +678,7 @@ cleanup_gem:
        i915_gem_fini(dev);
 cleanup_irq:
        intel_guc_fini(dev);
+cleanup_deffered_probe:
        drm_irq_uninstall(dev);
        intel_teardown_gmbus(dev);
 cleanup_csr:
drivers/gpu/drm/i915/i915_drv.h +1 -1
index 03e1bfa..a9eed22 100644
@@ -3778,7 +3778,7 @@ void intel_device_info_dump(struct drm_i915_private *dev_priv);
 
 /* modesetting */
 extern void intel_modeset_init_hw(struct drm_device *dev);
-extern void intel_modeset_init(struct drm_device *dev);
+extern int intel_modeset_init(struct drm_device *dev);
 extern void intel_modeset_gem_init(struct drm_device *dev);
 extern void intel_modeset_cleanup(struct drm_device *dev);
 extern int intel_connector_register(struct drm_connector *);
drivers/gpu/drm/i915/intel_display.c +19 -6
index be3b2ca..b1250f2 100644
@@ -14612,11 +14612,12 @@ static bool intel_crt_present(struct drm_device *dev)
        return true;
 }
 
-static void intel_setup_outputs(struct drm_device *dev)
+static int intel_setup_outputs(struct drm_device *dev)
 {
        struct drm_i915_private *dev_priv = to_i915(dev);
        struct intel_encoder *encoder;
        bool dpd_is_edp = false;
+       int ret = 0;
 
        /*
         * intel_edp_init_connector() depends on this completing first, to
@@ -14638,7 +14639,9 @@ static void intel_setup_outputs(struct drm_device *dev)
                intel_ddi_init(dev, PORT_B);
                intel_ddi_init(dev, PORT_C);
 
-               intel_dsi_init(dev);
+               ret = intel_dsi_init(dev);
+               if (ret == -EPROBE_DEFER)
+                       return ret;
        } else if (HAS_DDI(dev)) {
                int found;
 
@@ -14742,7 +14745,9 @@ static void intel_setup_outputs(struct drm_device *dev)
                                intel_hdmi_init(dev, CHV_HDMID, PORT_D);
                }
 
-               intel_dsi_init(dev);
+               ret = intel_dsi_init(dev);
+               if (ret == -EPROBE_DEFER)
+                       return ret;
        } else if (!IS_GEN2(dev) && !IS_PINEVIEW(dev)) {
                bool found = false;
 
@@ -14795,6 +14800,8 @@ static void intel_setup_outputs(struct drm_device *dev)
        intel_init_pch_refclk(dev);
 
        drm_helper_move_panel_connectors_to_head(dev);
+
+       return 0;
 }
 
 static void intel_user_framebuffer_destroy(struct drm_framebuffer *fb)
@@ -15539,7 +15546,7 @@ fail:
        drm_modeset_acquire_fini(&ctx);
 }
 
-void intel_modeset_init(struct drm_device *dev)
+int intel_modeset_init(struct drm_device *dev)
 {
        struct drm_i915_private *dev_priv = to_i915(dev);
        struct i915_ggtt *ggtt = &dev_priv->ggtt;
@@ -15564,7 +15571,7 @@ void intel_modeset_init(struct drm_device *dev)
        intel_init_pm(dev);
 
        if (INTEL_INFO(dev)->num_pipes == 0)
-               return;
+               return 0;
 
        /*
         * There may be no VBT; and if the BIOS enabled SSC we can
@@ -15632,7 +15639,11 @@ void intel_modeset_init(struct drm_device *dev)
 
        /* Just disable it once at startup */
        i915_disable_vga(dev);
-       intel_setup_outputs(dev);
+
+       /* Check if we encountered -EPROBE_DEFER while initializing DSI */
+       ret = intel_setup_outputs(dev);
+       if (ret)
+               return ret;
 
        drm_modeset_lock_all(dev);
        intel_modeset_setup_hw_state(dev);
@@ -15667,6 +15678,8 @@ void intel_modeset_init(struct drm_device *dev)
         * since the watermark calculation done here will use pstate->fb.
         */
        sanitize_watermarks(dev);
+
+       return 0;
 }
 
 static void intel_enable_pipe_a(struct drm_device *dev)
drivers/gpu/drm/i915/intel_drv.h +1 -1
index 55aeaf0..4f05b7c 100644
@@ -1418,7 +1418,7 @@ int intel_dp_aux_init_backlight_funcs(struct intel_connector *intel_connector);
 int intel_dp_mst_encoder_init(struct intel_digital_port *intel_dig_port, int conn_id);
 void intel_dp_mst_encoder_cleanup(struct intel_digital_port *intel_dig_port);
 /* intel_dsi.c */
-void intel_dsi_init(struct drm_device *dev);
+int intel_dsi_init(struct drm_device *dev);
 
 /* intel_dsi_dcs_backlight.c */
 int intel_dsi_dcs_init_backlight_funcs(struct intel_connector *intel_connector);
drivers/gpu/drm/i915/intel_dsi.c +17 -8
index de8e9fb..5c02a3f 100644
@@ -1422,7 +1422,7 @@ static void intel_dsi_add_properties(struct intel_connector *connector)
        }
 }
 
-void intel_dsi_init(struct drm_device *dev)
+int intel_dsi_init(struct drm_device *dev)
 {
        struct intel_dsi *intel_dsi;
        struct intel_encoder *intel_encoder;
@@ -1433,12 +1433,13 @@ void intel_dsi_init(struct drm_device *dev)
        struct drm_i915_private *dev_priv = to_i915(dev);
        enum port port;
        unsigned int i;
+       int ret = 0;
 
        DRM_DEBUG_KMS("\n");
 
        /* There is no detection method for MIPI so rely on VBT */
        if (!intel_bios_is_dsi_present(dev_priv, &port))
-               return;
+               return 0;
 
        if (IS_VALLEYVIEW(dev) || IS_CHERRYVIEW(dev)) {
                dev_priv->mipi_mmio_base = VLV_MIPI_BASE;
@@ -1446,17 +1447,17 @@ void intel_dsi_init(struct drm_device *dev)
                dev_priv->mipi_mmio_base = BXT_MIPI_BASE;
        } else {
                DRM_ERROR("Unsupported Mipi device to reg base");
-               return;
+               return 0;
        }
 
        intel_dsi = kzalloc(sizeof(*intel_dsi), GFP_KERNEL);
        if (!intel_dsi)
-               return;
+               return -ENOMEM;
 
        intel_connector = intel_connector_alloc();
        if (!intel_connector) {
                kfree(intel_dsi);
-               return;
+               return -ENOMEM;
        }
 
        intel_encoder = &intel_dsi->base;
@@ -1560,6 +1561,9 @@ void intel_dsi_init(struct drm_device *dev)
                if (IS_ERR(intel_dsi->gpio_panel)) {
                        DRM_ERROR("Failed to own gpio for panel control\n");
                        intel_dsi->gpio_panel = NULL;
+
+                       ret = -EPROBE_DEFER;
+                       goto err;
                }
        }
 
@@ -1597,14 +1601,20 @@ void intel_dsi_init(struct drm_device *dev)
        connector->display_info.height_mm = fixed_mode->height_mm;
 
        intel_panel_init(&intel_connector->panel, fixed_mode, NULL);
-       intel_panel_setup_backlight(connector, INVALID_PIPE);
+       ret = intel_panel_setup_backlight(connector, INVALID_PIPE);
+       if (ret == -ENODEV) {
+               ret = -EPROBE_DEFER;
+               goto err;
+       }
 
        intel_dsi_add_properties(intel_connector);
 
-       return;
+       return 0;
 
 err:
        drm_encoder_cleanup(&intel_encoder->base);
        kfree(intel_dsi);
        kfree(intel_connector);
+
+       return ret;
 }
--

2.5.5

Quoted 4 lines

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw
Quoted 12 lines · Shobhit Kumar
Quoted 7 lines · Shobhit Kumar

On devices that have MIPI DSI panel control and PWM control comming from CRC PMIC, we need the gpio and pwm exported from the intel_soc_pmic driver. Defer probing for later in case we fail to get these devices.

v2: Rebased on latest drm-intel-nightly
Added failure check for pwm_get which got missed out

[snip]

Quoted 11 lines

drivers/gpu/drm/i915/i915_drv.c static int i915_load_modeset_init(struct drm_device *dev) · line 653

Quoted 11 lines
drivers/gpu/drm/i915/i915_drv.c +3 -0
index b9a8117..9bfe0c8 100644
@@ -648,6 +648,9 @@ static int i915_load_modeset_init(struct drm_device *dev)
        /* Important: The output setup functions called by modeset_init need
         * working irqs for e.g. gmbus and dp aux transfers. */
        intel_modeset_init(dev);
+       ret = intel_modeset_init(dev);
+       if (ret == -EPROBE_DEFER)
+               goto cleanup_deffered_probe;

Did you intend to call intel_modeset_init twice? In my tests, I removed the first copy because it seemed like a mistake.

Quoted 17 lines
Quoted 17 lines
drivers/gpu/drm/i915/i915_drv.c +1 -0
        intel_guc_init(dev);
 
@@ -675,6 +678,7 @@ cleanup_gem:
        i915_gem_fini(dev);
 cleanup_irq:
        intel_guc_fini(dev);
+cleanup_deffered_probe:
        drm_irq_uninstall(dev);
        intel_teardown_gmbus(dev);
 cleanup_csr:
drivers/gpu/drm/i915/i915_drv.h +0 -0
index 03e1bfa..a9eed22 100644
@@ -3778,7 +3778,7 @@ void intel_device_info_dump(struct drm_i915_private *dev_priv);
 
Quoted 10 lines

drivers/gpu/drm/i915/intel_display.c

Quoted 10 lines
drivers/gpu/drm/i915/i915_drv.h +1 -1
 /* modesetting */
 extern void intel_modeset_init_hw(struct drm_device *dev);
-extern void intel_modeset_init(struct drm_device *dev);
+extern int intel_modeset_init(struct drm_device *dev);
 extern void intel_modeset_gem_init(struct drm_device *dev);
 extern void intel_modeset_cleanup(struct drm_device *dev);
 extern int intel_connector_register(struct drm_connector *);
drivers/gpu/drm/i915/intel_display.c +0 -0
index be3b2ca..b1250f2 100644
[snip]

When testing on drm-intel-nightly, my system froze with your patch. I can't get a full dmesg because I haven't yet found a way to trigger the problem after I can get an ssh session up.

The relevant logs I see before freeze are:
[drm] Initialized drm 1.1.0 20060810
[drm] Memory usable by graphics device = 2048M
fb: switching to inteldrmfb from EFI VGA

console is stuck at this point, my guess is that modeset fails and that isn't handled well. The screen does not go black, the log messages just stay on screen indefinitely.

If I blacklist i915 and let X load the module (or manually load it later), everything seems to run fine and backlight works, but that was also true before applying the patch.

Regards,
Stephen
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw
Quoted 13 lines · Stephen J
Quoted 12 lines · Shobhit Kumar
Quoted 7 lines · Shobhit Kumar

On devices that have MIPI DSI panel control and PWM control comming from CRC PMIC, we need the gpio and pwm exported from the intel_soc_pmic driver. Defer probing for later in case we fail to get these devices.

v2: Rebased on latest drm-intel-nightly
Added failure check for pwm_get which got missed out

[snip]

Quoted 15 lines
Quoted 11 lines

drivers/gpu/drm/i915/i915_drv.c static int i915_load_modeset_init(struct drm_device *dev) · line 653

Quoted 11 lines
drivers/gpu/drm/i915/i915_drv.c +3 -0
index b9a8117..9bfe0c8 100644
@@ -648,6 +648,9 @@ static int i915_load_modeset_init(struct drm_device *dev)
        /* Important: The output setup functions called by modeset_init need
         * working irqs for e.g. gmbus and dp aux transfers. */
        intel_modeset_init(dev);
+       ret = intel_modeset_init(dev);
+       if (ret == -EPROBE_DEFER)
+               goto cleanup_deffered_probe;

Did you intend to call intel_modeset_init twice? In my tests, I removed the first copy because it seemed like a mistake.

Nope I did not. It was a mistake. Thanks for pointing out.

Quoted 32 lines
Quoted 17 lines
Quoted 17 lines
drivers/gpu/drm/i915/i915_drv.c +1 -0
        intel_guc_init(dev);
 
@@ -675,6 +678,7 @@ cleanup_gem:
        i915_gem_fini(dev);
 cleanup_irq:
        intel_guc_fini(dev);
+cleanup_deffered_probe:
        drm_irq_uninstall(dev);
        intel_teardown_gmbus(dev);
 cleanup_csr:
drivers/gpu/drm/i915/i915_drv.h +0 -0
index 03e1bfa..a9eed22 100644
@@ -3778,7 +3778,7 @@ void intel_device_info_dump(struct drm_i915_private *dev_priv);
 
Quoted 10 lines

drivers/gpu/drm/i915/intel_display.c

Quoted 10 lines
drivers/gpu/drm/i915/i915_drv.h +1 -1
 /* modesetting */
 extern void intel_modeset_init_hw(struct drm_device *dev);
-extern void intel_modeset_init(struct drm_device *dev);
+extern int intel_modeset_init(struct drm_device *dev);
 extern void intel_modeset_gem_init(struct drm_device *dev);
 extern void intel_modeset_cleanup(struct drm_device *dev);
 extern int intel_connector_register(struct drm_connector *);
drivers/gpu/drm/i915/intel_display.c +0 -0
index be3b2ca..b1250f2 100644
[snip]

When testing on drm-intel-nightly, my system froze with your patch. I can't get a full dmesg because I haven't yet found a way to trigger the problem after I can get an ssh session up.

Quoted 8 lines

The relevant logs I see before freeze are:
[drm] Initialized drm 1.1.0 20060810
[drm] Memory usable by graphics device = 2048M
fb: switching to inteldrmfb from EFI VGA

console is stuck at this point, my guess is that modeset fails and that isn't handled well. The screen does not go black, the log messages just stay on screen indefinitely.

Will try to force deferred probe on one of my device which has serial console to get the serial logs and debug deferred probe in general.

Regards
Shobhit

Quoted 7 lines

If I blacklist i915 and let X load the module (or manually load it later), everything seems to run fine and backlight works, but that was also true before applying the patch.

Regards,
Stephen

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw

✗ Ro.CI.BAT: warning for drm/i915: Return -EPROBE_DEFER if we cannot get GPIO or PWM in dsi_init

In reply to Shobhit Kumar
== Series Details ==

== Series Details ==

Series: drm/i915: Return -EPROBE_DEFER if we cannot get GPIO or PWM in dsi_init
URL : https://patchwork.freedesktop.org/series/9918/
State : warning

== Summary ==

Series 9918v1 drm/i915: Return -EPROBE_DEFER if we cannot get GPIO or PWM in dsi_init
http://patchwork.freedesktop.org/api/1.0/series/9918/revisions/1/mbox

Test core_auth:

        Subgroup basic-auth:
                pass       -> SKIP       (ro-bdw-i7-5557U)
                pass       -> SKIP       (ro-ilk1-i5-650)
                pass       -> SKIP       (ro-hsw-i3-4010u)
                pass       -> SKIP       (fi-skl-i5-6260u)
                pass       -> SKIP       (ro-bdw-i7-5600u)
                pass       -> SKIP       (ro-snb-i7-2620M)
                pass       -> SKIP       (ro-bdw-i5-5250u)
                pass       -> SKIP       (ro-hsw-i7-4770r)
                pass       -> SKIP       (fi-snb-i7-2600)
                pass       -> SKIP       (ro-ivb-i7-3770)
                pass       -> SKIP       (fi-skl-i7-6700k)
                pass       -> SKIP       (ro-skl3-i5-6260u)
Test core_prop_blob:
        Subgroup basic:
                pass       -> SKIP       (ro-bdw-i7-5557U)
                pass       -> SKIP       (ro-ilk1-i5-650)
                pass       -> SKIP       (ro-hsw-i3-4010u)
                pass       -> SKIP       (fi-skl-i5-6260u)
                pass       -> SKIP       (ro-bdw-i7-5600u)
                pass       -> SKIP       (ro-snb-i7-2620M)
                pass       -> SKIP       (ro-bdw-i5-5250u)
                pass       -> SKIP       (ro-hsw-i7-4770r)
                pass       -> SKIP       (fi-snb-i7-2600)
                pass       -> SKIP       (ro-ivb-i7-3770)
                pass       -> SKIP       (fi-skl-i7-6700k)
                pass       -> SKIP       (ro-skl3-i5-6260u)
Test drv_getparams_basic:
        Subgroup basic-eu-total:
                pass       -> SKIP       (ro-bdw-i7-5557U)
                pass       -> SKIP       (ro-ilk1-i5-650)
                pass       -> SKIP       (ro-hsw-i3-4010u)
                pass       -> SKIP       (fi-skl-i5-6260u)
                pass       -> SKIP       (ro-bdw-i7-5600u)
                pass       -> SKIP       (ro-snb-i7-2620M)
                pass       -> SKIP       (ro-bdw-i5-5250u)
                pass       -> SKIP       (ro-hsw-i7-4770r)
                pass       -> SKIP       (fi-snb-i7-2600)
                pass       -> SKIP       (ro-ivb-i7-3770)
                pass       -> SKIP       (fi-skl-i7-6700k)
                pass       -> SKIP       (ro-skl3-i5-6260u)
        Subgroup basic-subslice-total:
                pass       -> SKIP       (ro-bdw-i7-5557U)
                pass       -> SKIP       (ro-ilk1-i5-650)
                pass       -> SKIP       (ro-hsw-i3-4010u)
                pass       -> SKIP       (fi-skl-i5-6260u)
                pass       -> SKIP       (ro-bdw-i7-5600u)
                pass       -> SKIP       (ro-snb-i7-2620M)
                pass       -> SKIP       (ro-bdw-i5-5250u)
                pass       -> SKIP       (ro-hsw-i7-4770r)
                pass       -> SKIP       (fi-snb-i7-2600)
                pass       -> SKIP       (ro-ivb-i7-3770)
                pass       -> SKIP       (fi-skl-i7-6700k)
                pass       -> SKIP       (ro-skl3-i5-6260u)
Test drv_hangman:
        Subgroup error-state-basic:
                pass       -> SKIP       (ro-bdw-i7-5557U)
                pass       -> SKIP       (ro-ilk1-i5-650)
                pass       -> SKIP       (ro-hsw-i3-4010u)
                pass       -> SKIP       (fi-skl-i5-6260u)
                pass       -> SKIP       (ro-bdw-i7-5600u)
                pass       -> SKIP       (ro-snb-i7-2620M)
                pass       -> SKIP       (ro-bdw-i5-5250u)
                pass       -> SKIP       (ro-hsw-i7-4770r)
                pass       -> SKIP       (fi-snb-i7-2600)
                pass       -> SKIP       (ro-ivb-i7-3770)
                pass       -> SKIP       (fi-skl-i7-6700k)
                pass       -> SKIP       (ro-skl3-i5-6260u)
Test drv_module_reload_basic:
                pass       -> SKIP       (ro-bdw-i7-5557U)
                pass       -> SKIP       (ro-ilk1-i5-650)
                pass       -> SKIP       (ro-hsw-i3-4010u)
                pass       -> SKIP       (fi-skl-i5-6260u)
                pass       -> SKIP       (ro-bdw-i7-5600u)
                pass       -> SKIP       (ro-bdw-i5-5250u)
                pass       -> SKIP       (ro-snb-i7-2620M)
                pass       -> SKIP       (ro-hsw-i7-4770r)
                pass       -> SKIP       (fi-snb-i7-2600)
                pass       -> SKIP       (fi-skl-i7-6700k)
                dmesg-warn -> SKIP       (ro-skl3-i5-6260u)
Test gem_basic:
        Subgroup bad-close:
                pass       -> SKIP       (ro-bdw-i7-5557U)
                pass       -> SKIP       (ro-ilk1-i5-650)
                pass       -> SKIP       (ro-hsw-i3-4010u)
                pass       -> SKIP       (fi-skl-i5-6260u)
                pass       -> SKIP       (ro-bdw-i7-5600u)
                pass       -> SKIP       (ro-snb-i7-2620M)
                pass       -> SKIP       (ro-bdw-i5-5250u)
                pass       -> SKIP       (ro-hsw-i7-4770r)
                pass       -> SKIP       (fi-snb-i7-2600)
                pass       -> SKIP       (ro-ivb-i7-3770)
                pass       -> SKIP       (fi-skl-i7-6700k)
                pass       -> SKIP       (ro-skl3-i5-6260u)
        Subgroup create-close:
                pass       -> SKIP       (ro-bdw-i7-5557U)

WARNING: Long output truncated
ro-byt-n2820 failed to connect after reboot

Results at /archive/results/CI_IGT_test/RO_Patchwork_1497/

c01b445 drm-intel-nightly: 2016y-07m-15d-07h-02m-07s UTC integration manifest dc20609 drm/i915: Return -EPROBE_DEFER if we cannot get GPIO or PWM in dsi_init

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx