cooker: Fix incorrect dot file generation
PATCH 1/1 cooker: Fix incorrect dot file generation
In the runqueue cleanup/conversion, "dep" was mistakenly used where "tid" should be leading to incorrect task-depends.dot files and causing general confusion. Fix this, its clearly incorrect looking at the code.
Signed-off-by Richard Purdie <[email protected]>
bitbake/lib/bb/cooker.py +1 -1
@@ -744,7 +744,7 @@ class BBCooker: for dep in rq.rqdata.runtaskentries[tid].depends: depfn = bb.runqueue.fn_from_tid(dep) deppn = self.recipecache.pkg_fn[depfn] - dotname = "%s.%s" % (pn, bb.runqueue.taskname_from_tid(dep)) + dotname = "%s.%s" % (pn, bb.runqueue.taskname_from_tid(tid)) if not dotname in depend_tree["tdepends"]: depend_tree["tdepends"][dotname] = [] depend_tree["tdepends"][dotname].append("%s.%s" % (deppn, bb.runqueue.taskname_from_tid(dep)))
Quoted 11 lines · Richard Purdie
In the runqueue cleanup/conversion, "dep" was mistakenly used where "tid" should be leading to incorrect task-depends.dot files and causing general confusion. Fix this, its clearly incorrect looking at the code.
Signed-off-by Richard Purdie <[email protected]>bitbake/lib/bb/cooker.py +0
-0
bitbake/lib/bb/cooker.py class BBCooker: · line 750
Quoted 8 lines
bitbake/lib/bb/cooker.py +1
-1@@ -744,7 +744,7 @@ class BBCooker: for dep in rq.rqdata.runtaskentries[tid].depends: depfn = bb.runqueue.fn_from_tid(dep) deppn = self.recipecache.pkg_fn[depfn] - dotname = "%s.%s" % (pn, bb.runqueue.taskname_from_tid(dep)) + dotname = "%s.%s" % (pn, bb.runqueue.taskname_from_tid(tid)) if not dotname in depend_tree["tdepends"]: depend_tree["tdepends"][dotname] = [] depend_tree["tdepends"][dotname].append("%s.%s" % (deppn, bb.runqueue.taskname_from_tid(dep)))
+1, this is indeed fixing the issue I was seeing. Thanks!
Signature · 6 lines
Best Regards, Patrick Ohly The content of this message is my personal opinion only and although I am an employee of Intel, the statements I make here in no way represent Intel's position on the issue, nor am I authorized to speak on behalf of Intel on this matter.