Skip to contentSkip to conversation

Patch "ALSA: ctl: Stop notification after disconnection" has been added to the 3.14-stable tree

PATCH [email protected] 1 participant 1 message Jul 25, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

ALSA: ctl: Stop notification after disconnection

to the 3.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
alsa-ctl-stop-notification-after-disconnection.patch
and it can be found in the queue-3.14 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From f388cdcdd160687c6650833f286b9c89c50960ff Mon Sep 17 00:00:00 2001

From: Takashi Iwai <[email protected]>
Date: Fri, 8 Jul 2016 08:05:19 +0200
Subject: ALSA: ctl: Stop notification after disconnection

From: Takashi Iwai <[email protected]>

commit f388cdcdd160687c6650833f286b9c89c50960ff upstream.

snd_ctl_remove() has a notification for the removal event. It's superfluous when done during the device got disconnected. Although the notification itself is mostly harmless, it may potentially be harmful, and should be suppressed. Actually some components PCM may free ctl elements during the disconnect or free callbacks, thus it's no theoretical issue.

This patch adds the check of card->shutdown flag for avoiding unnecessary notifications after (or during) the disconnect.

---
 sound/core/control.c |    2 ++
 1 file changed, 2 insertions(+)
sound/core/control.c +2 -0
@@ -150,6 +150,8 @@ void snd_ctl_notify(struct snd_card *car
 	
 	if (snd_BUG_ON(!card || !id))
 		return;
+	if (card->shutdown)
+		return;
 	read_lock(&card->ctl_files_rwlock);
 #if defined(CONFIG_SND_MIXER_OSS) || defined(CONFIG_SND_MIXER_OSS_MODULE)
 	card->mixer_oss_change_count++;

Patches currently in stable-queue which might be from [email protected] are

queue-3.14/alsa-ctl-stop-notification-after-disconnection.patch queue-3.14/alsa-dummy-fix-a-use-after-free-at-closing.patch queue-3.14/alsa-au88x0-fix-calculation-in-vortex_wtdma_bufshift.patch