Skip to contentSkip to conversation

Patch "tmpfs: don't undo fallocate past its last page" has been added to the 3.14-stable tree

PATCH [email protected] 1 participant 1 message Jul 25, 2016

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

tmpfs: don't undo fallocate past its last page

to the 3.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
tmpfs-don-t-undo-fallocate-past-its-last-page.patch
and it can be found in the queue-3.14 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From b9b4bb26af017dbe930cd4df7f9b2fc3a0497bfe Mon Sep 17 00:00:00 2001

From: Anthony Romano <[email protected]>
Date: Fri, 24 Jun 2016 14:48:43 -0700
Subject: tmpfs: don't undo fallocate past its last page

From: Anthony Romano <[email protected]>

commit b9b4bb26af017dbe930cd4df7f9b2fc3a0497bfe upstream.

When fallocate is interrupted it will undo a range that extends one byte past its range of allocated pages. This can corrupt an in-use page by zeroing out its first byte. Instead, undo using the inclusive byte range.

Fixes 1635f6a74152f1d ("tmpfs: undo fallocation on failure")
Cc Vlastimil Babka <[email protected]>
Cc Hugh Dickins <[email protected]>
Cc Brandon Philips <[email protected]>
---
 mm/shmem.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mm/shmem.c +1 -1
@@ -1895,7 +1895,7 @@ static long shmem_fallocate(struct file
 			/* Remove the !PageUptodate pages we added */
 			shmem_undo_range(inode,
 				(loff_t)start << PAGE_CACHE_SHIFT,
-				(loff_t)index << PAGE_CACHE_SHIFT, true);
+				((loff_t)index << PAGE_CACHE_SHIFT) - 1, true);
 			goto undone;
 		}
 

Patches currently in stable-queue which might be from [email protected] are

queue-3.14/tmpfs-don-t-undo-fallocate-past-its-last-page.patch