drm/ttm: add interface to export kernel_zone max memory size in ttm
Subsystems (4)
PATCH 1/2 drm/ttm: add interface to export kernel_zone max memory size in ttm
--- drivers/gpu/drm/ttm/ttm_memory.c | 6 ++++++ include/drm/ttm/ttm_memory.h | 1 + 2 files changed, 7 insertions(+)
drivers/gpu/drm/ttm/ttm_memory.c +6 -0
@@ -600,3 +600,9 @@ size_t ttm_round_pot(size_t size)return 0 ; }EXPORT_SYMBOL (ttm_round_pot); + +uint64_t ttm_get_kernel_zone_memory_size (struct ttm_mem_global *glob) +{ +return glob->zone_kernel->max_mem; +} +EXPORT_SYMBOL (ttm_get_kernel_zone_memory_size);
include/drm/ttm/ttm_memory.h +1 -0
@@ -155,4 +155,5 @@ extern int ttm_mem_global_alloc_page(struct ttm_mem_global *glob,extern void ttm_mem_global_free_page (struct ttm_mem_global *glob,struct page *page);extern size_t ttm_round_pot (size_t size); +extern uint64_t ttm_get_kernel_zone_memory_size (struct ttm_mem_global *glob);#endif
Signature · 6 lines
2.7.4 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 1469618515-30670-1-git-send-email-Qingqing.Wang-5C7GfCeVMHo@public.gmane.org
PATCH 2/2 drm/amdgpu: use the kernel zone memory size as the max remote memory in amdgpu
--- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 12 +++++++----- drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c | 7 ++++++- drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c | 7 ++++++- 4 files changed, 21 insertions(+), 7 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu.h +2 -0
@@ -2432,6 +2432,8 @@ uint32_t amdgpu_ttm_tt_pte_flags(struct amdgpu_device *adev, struct ttm_tt *ttm,void amdgpu_vram_location (struct amdgpu_device *adev,struct amdgpu_mc *mc,u64 base);void amdgpu_gtt_location (struct amdgpu_device *adev,struct amdgpu_mc *mc);void amdgpu_ttm_set_active_vram_size (struct amdgpu_device *adev,u64 size); +u64 amdgpu_ttm_get_gtt_mem_size (struct amdgpu_device *adev); +int amdgpu_ttm_global_init (struct amdgpu_device *adev);void amdgpu_program_register_sequence (struct amdgpu_device *adev,const u32 *registers,const u32 array_size);
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c +7 -5
@@ -34,6 +34,7 @@#include <ttm/ttm_placement.h> #include <ttm/ttm_module.h> #include <ttm/ttm_page_alloc.h> +#include <ttm/ttm_memory.h> #include <drm/drmP.h> #include <drm/amdgpu_drm.h> #include <linux/seq_file.h>
@@ -74,7 +75,7 @@ static void amdgpu_ttm_mem_global_release(struct drm_global_reference *ref)ttm_mem_global_release (ref->object); } -static int amdgpu_ttm_global_init (struct amdgpu_device *adev) +int amdgpu_ttm_global_init (struct amdgpu_device *adev) {struct drm_global_reference *global_ref;struct amdgpu_ring *ring;
@@ -998,10 +999,6 @@ int amdgpu_ttm_init(struct amdgpu_device *adev)unsigned i, j;int r; - r =amdgpu_ttm_global_init (adev); -if (r) { -return r; - }/* No others user of address space so set it to 0 */ r = ttm_bo_device_init(&adev->mman.bdev, adev->mman.bo_global_ref.ref.object,
@@ -1398,3 +1395,8 @@ static void amdgpu_ttm_debugfs_fini(struct amdgpu_device *adev)#endif } + +u64 amdgpu_ttm_get_gtt_mem_size (struct amdgpu_device *adev) +{ +return ttm_get_kernel_zone_memory_size (adev->mman.mem_global_ref.object); +}
drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c +6 -1
@@ -392,7 +392,7 @@ static int gmc_v7_0_mc_init(struct amdgpu_device *adev)* size equal to the 1024 or vram, whichever is larger. */ if (amdgpu_gart_size ==-1 ) - adev->mc.gtt_size =max ((1024ULL <<20 ), adev->mc.mc_vram_size); + adev->mc.gtt_size =amdgpu_ttm_get_gtt_mem_size (adev);else adev->mc.gtt_size = (uint64_t )amdgpu_gart_size <<20 ;
@@ -959,6 +959,11 @@ static int gmc_v7_0_sw_init(void *handle)return r; } + r =amdgpu_ttm_global_init (adev); +if (r) { +return r; + } + r =gmc_v7_0_mc_init (adev);if (r)return r;
drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c +6 -1
@@ -469,7 +469,7 @@ static int gmc_v8_0_mc_init(struct amdgpu_device *adev)* size equal to the 1024 or vram, whichever is larger. */ if (amdgpu_gart_size ==-1 ) - adev->mc.gtt_size =max ((1024ULL <<20 ), adev->mc.mc_vram_size); + adev->mc.gtt_size =amdgpu_ttm_get_gtt_mem_size (adev);else adev->mc.gtt_size = (uint64_t )amdgpu_gart_size <<20 ;
@@ -956,6 +956,11 @@ static int gmc_v8_0_sw_init(void *handle)return r; } + r =amdgpu_ttm_global_init (adev); +if (r) { +return r; + } + r =gmc_v8_0_mc_init (adev);if (r)return r;
Signature · 6 lines
2.7.4 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 1469618515-30670-2-git-send-email-Qingqing.Wang-5C7GfCeVMHo@public.gmane.org
Re: [PATCH 2/2] drm/amdgpu: use the kernel zone memory size as the max remote memory in amdgpu
Quoted 68 lines · Ken Wang
Change-Id Ibf193cc2d9e20c3aefa1ce8ff24241dfbb6768ffSigned-off-by Ken Wang <[email protected]>--- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 12 +++++++----- drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c | 7 ++++++- drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c | 7 ++++++- 4 files changed, 21 insertions(+), 7 deletions(-)drivers/gpu/drm/amd/amdgpu/amdgpu.h +2
-0@@ -2432,6 +2432,8 @@ uint32_t amdgpu_ttm_tt_pte_flags(struct amdgpu_device *adev, struct ttm_tt *ttm,void amdgpu_vram_location (struct amdgpu_device *adev,struct amdgpu_mc *mc,u64 base);void amdgpu_gtt_location (struct amdgpu_device *adev,struct amdgpu_mc *mc);void amdgpu_ttm_set_active_vram_size (struct amdgpu_device *adev,u64 size); +u64 amdgpu_ttm_get_gtt_mem_size (struct amdgpu_device *adev); +int amdgpu_ttm_global_init (struct amdgpu_device *adev);void amdgpu_program_register_sequence (struct amdgpu_device *adev,const u32 *registers,const u32 array_size);drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c +7
-5@@ -34,6 +34,7 @@#include <ttm/ttm_placement.h> #include <ttm/ttm_module.h> #include <ttm/ttm_page_alloc.h> +#include <ttm/ttm_memory.h> #include <drm/drmP.h> #include <drm/amdgpu_drm.h> #include <linux/seq_file.h> @@ -74,7 +75,7 @@ static void amdgpu_ttm_mem_global_release(struct drm_global_reference *ref)ttm_mem_global_release (ref->object); } -static int amdgpu_ttm_global_init (struct amdgpu_device *adev) +int amdgpu_ttm_global_init (struct amdgpu_device *adev) {struct drm_global_reference *global_ref;struct amdgpu_ring *ring;@@ -998,10 +999,6 @@ int amdgpu_ttm_init(struct amdgpu_device *adev)unsigned i, j;int r; - r =amdgpu_ttm_global_init (adev); -if (r) { -return r; - }/* No others user of address space so set it to 0 */ r = ttm_bo_device_init(&adev->mman.bdev, adev->mman.bo_global_ref.ref.object,@@ -1398,3 +1395,8 @@ static void amdgpu_ttm_debugfs_fini(struct amdgpu_device *adev)#endif } + +u64 amdgpu_ttm_get_gtt_mem_size (struct amdgpu_device *adev) +{ +return ttm_get_kernel_zone_memory_size (adev->mman.mem_global_ref.object); +}drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c +0
-0
drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c static int gmc_v7_0_mc_init(struct amdgpu_device *adev) · line 395
Quoted 5 lines
drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c +1
-1@@ -392,7 +392,7 @@ static int gmc_v7_0_mc_init(struct amdgpu_device *adev)* size equal to the 1024 or vram, whichever is larger. */ if (amdgpu_gart_size ==-1 ) - adev->mc.gtt_size =max ((1024ULL <<20 ), adev->mc.mc_vram_size); + adev->mc.gtt_size =amdgpu_ttm_get_gtt_mem_size (adev);
Do we want to limit this to the min(amdgpu_ttm_get_gtt_mem_size, GPU address space - vram)? GPU address space is only 40 bits. You could theoretically have systems with a lot of system memory.
Alex
Quoted 43 lines
drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c +5
-0else adev->mc.gtt_size = (uint64_t )amdgpu_gart_size <<20 ;@@ -959,6 +959,11 @@ static int gmc_v7_0_sw_init(void *handle)return r; } + r =amdgpu_ttm_global_init (adev); +if (r) { +return r; + } + r =gmc_v7_0_mc_init (adev);if (r)return r;drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c +6
-2@@ -469,7 +469,7 @@ static int gmc_v8_0_mc_init(struct amdgpu_device *adev)* size equal to the 1024 or vram, whichever is larger. */ if (amdgpu_gart_size ==-1 ) - adev->mc.gtt_size =max ((1024ULL <<20 ), adev->mc.mc_vram_size); + adev->mc.gtt_size =amdgpu_ttm_get_gtt_mem_size (adev);else adev->mc.gtt_size = (uint64_t )amdgpu_gart_size <<20 ;@@ -956,6 +956,11 @@ static int gmc_v8_0_sw_init(void *handle)return r; } + r =amdgpu_ttm_global_init (adev); +if (r) { +return r; + } + r =gmc_v8_0_mc_init (adev);if (r)return r; --2.7.4
Quoted 4 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): CADnq5_OmhXSmTkDZhZTBN8OSASksCwd72sogmbCJroCHbq2QuA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org
答复: [PATCH 2/2] drm/amdgpu: use the kernel zone memory size as the max remote memory in amdgpu
Yeah, that's could be an issue, I have changed the logic and send the review again.
________________________________
发件人: Alex Deucher <[email protected]>
发送时间: 2016年8月2日 12:56:07
收件人: Wang, Ken
抄送: amd-gfx list
主题: Re: [PATCH 2/2] drm/amdgpu: use the kernel zone memory size as the max remote memory in amdgpu
Quoted 68 lines · Ken Wang
Change-Id Ibf193cc2d9e20c3aefa1ce8ff24241dfbb6768ffSigned-off-by Ken Wang <[email protected]>--- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 12 +++++++----- drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c | 7 ++++++- drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c | 7 ++++++- 4 files changed, 21 insertions(+), 7 deletions(-)drivers/gpu/drm/amd/amdgpu/amdgpu.h +2
-0@@ -2432,6 +2432,8 @@ uint32_t amdgpu_ttm_tt_pte_flags(struct amdgpu_device *adev, struct ttm_tt *ttm,void amdgpu_vram_location (struct amdgpu_device *adev,struct amdgpu_mc *mc,u64 base);void amdgpu_gtt_location (struct amdgpu_device *adev,struct amdgpu_mc *mc);void amdgpu_ttm_set_active_vram_size (struct amdgpu_device *adev,u64 size); +u64 amdgpu_ttm_get_gtt_mem_size (struct amdgpu_device *adev); +int amdgpu_ttm_global_init (struct amdgpu_device *adev);void amdgpu_program_register_sequence (struct amdgpu_device *adev,const u32 *registers,const u32 array_size);drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c +7
-5@@ -34,6 +34,7 @@#include <ttm/ttm_placement.h> #include <ttm/ttm_module.h> #include <ttm/ttm_page_alloc.h> +#include <ttm/ttm_memory.h> #include <drm/drmP.h> #include <drm/amdgpu_drm.h> #include <linux/seq_file.h> @@ -74,7 +75,7 @@ static void amdgpu_ttm_mem_global_release(struct drm_global_reference *ref)ttm_mem_global_release (ref->object); } -static int amdgpu_ttm_global_init (struct amdgpu_device *adev) +int amdgpu_ttm_global_init (struct amdgpu_device *adev) {struct drm_global_reference *global_ref;struct amdgpu_ring *ring;@@ -998,10 +999,6 @@ int amdgpu_ttm_init(struct amdgpu_device *adev)unsigned i, j;int r; - r =amdgpu_ttm_global_init (adev); -if (r) { -return r; - }/* No others user of address space so set it to 0 */ r = ttm_bo_device_init(&adev->mman.bdev, adev->mman.bo_global_ref.ref.object,@@ -1398,3 +1395,8 @@ static void amdgpu_ttm_debugfs_fini(struct amdgpu_device *adev)#endif } + +u64 amdgpu_ttm_get_gtt_mem_size (struct amdgpu_device *adev) +{ +return ttm_get_kernel_zone_memory_size (adev->mman.mem_global_ref.object); +}drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c +0
-0
drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c static int gmc_v7_0_mc_init(struct amdgpu_device *adev) · line 395
Quoted 5 lines
drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c +1
-1@@ -392,7 +392,7 @@ static int gmc_v7_0_mc_init(struct amdgpu_device *adev)* size equal to the 1024 or vram, whichever is larger. */ if (amdgpu_gart_size ==-1 ) - adev->mc.gtt_size =max ((1024ULL <<20 ), adev->mc.mc_vram_size); + adev->mc.gtt_size =amdgpu_ttm_get_gtt_mem_size (adev);
Do we want to limit this to the min(amdgpu_ttm_get_gtt_mem_size, GPU address space - vram)? GPU address space is only 40 bits. You could theoretically have systems with a lot of system memory.
Alex
Quoted 43 lines
drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c +5
-0else adev->mc.gtt_size = (uint64_t )amdgpu_gart_size <<20 ;@@ -959,6 +959,11 @@ static int gmc_v7_0_sw_init(void *handle)return r; } + r =amdgpu_ttm_global_init (adev); +if (r) { +return r; + } + r =gmc_v7_0_mc_init (adev);if (r)return r;drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c +6
-2@@ -469,7 +469,7 @@ static int gmc_v8_0_mc_init(struct amdgpu_device *adev)* size equal to the 1024 or vram, whichever is larger. */ if (amdgpu_gart_size ==-1 ) - adev->mc.gtt_size =max ((1024ULL <<20 ), adev->mc.mc_vram_size); + adev->mc.gtt_size =amdgpu_ttm_get_gtt_mem_size (adev);else adev->mc.gtt_size = (uint64_t )amdgpu_gart_size <<20 ;@@ -956,6 +956,11 @@ static int gmc_v8_0_sw_init(void *handle)return r; } + r =amdgpu_ttm_global_init (adev); +if (r) { +return r; + } + r =gmc_v8_0_mc_init (adev);if (r)return r; --2.7.4
Quoted 4 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Alex Deucher
Reviewed-byQuoted 2 lines · Ken Wang
Change-Id I9f30b54365492b234a7f0887dd0c67a9817c3705Signed-off-by Ken Wang <[email protected]>
Adding dri-devel as well since ttm is a common component.
Quoted 32 lines
--- drivers/gpu/drm/ttm/ttm_memory.c | 6 ++++++ include/drm/ttm/ttm_memory.h | 1 + 2 files changed, 7 insertions(+)drivers/gpu/drm/ttm/ttm_memory.c +6
-0@@ -600,3 +600,9 @@ size_t ttm_round_pot(size_t size)return 0 ; }EXPORT_SYMBOL (ttm_round_pot); + +uint64_t ttm_get_kernel_zone_memory_size (struct ttm_mem_global *glob) +{ +return glob->zone_kernel->max_mem; +} +EXPORT_SYMBOL (ttm_get_kernel_zone_memory_size);include/drm/ttm/ttm_memory.h +1
-1@@ -155,4 +155,5 @@ extern int ttm_mem_global_alloc_page(struct ttm_mem_global *glob,extern void ttm_mem_global_free_page (struct ttm_mem_global *glob,struct page *page);extern size_t ttm_round_pot (size_t size); +extern uint64_t ttm_get_kernel_zone_memory_size (struct ttm_mem_global *glob);#endif --2.7.4
Quoted 4 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): CADnq5_PGu1v1Z7o5QwJ8eyr5BKBX_XG6MLNXB2WhztYkT4pH9w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org
Am 02.08.2016 um 06:57 schrieb Alex Deucher:
Quoted 6 lines · Ken Wang
Quoted 2 lines
Change-Id I9f30b54365492b234a7f0887dd0c67a9817c3705Signed-off-by Ken Wang <[email protected]>Adding dri-devel as well since ttm is a common component.
Reviewed-by Alex Deucher <[email protected]>
A bit commit message would be nice, e.g. something like "Add a function to get the maximum memory used by the kernel zone."
With that fixed he patch is Reviewed-by: Christian König <[email protected]> as well.
Regards,
Christian.
Quoted 33 lines
Quoted 33 lines
--- drivers/gpu/drm/ttm/ttm_memory.c | 6 ++++++ include/drm/ttm/ttm_memory.h | 1 + 2 files changed, 7 insertions(+)drivers/gpu/drm/ttm/ttm_memory.c +6
-0@@ -600,3 +600,9 @@ size_t ttm_round_pot(size_t size)return 0 ; }EXPORT_SYMBOL (ttm_round_pot); + +uint64_t ttm_get_kernel_zone_memory_size (struct ttm_mem_global *glob) +{ +return glob->zone_kernel->max_mem; +} +EXPORT_SYMBOL (ttm_get_kernel_zone_memory_size);include/drm/ttm/ttm_memory.h +1
-1@@ -155,4 +155,5 @@ extern int ttm_mem_global_alloc_page(struct ttm_mem_global *glob,extern void ttm_mem_global_free_page (struct ttm_mem_global *glob,struct page *page);extern size_t ttm_round_pot (size_t size); +extern uint64_t ttm_get_kernel_zone_memory_size (struct ttm_mem_global *glob);#endif --2.7.4
Quoted 8 lines
Quoted 4 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx