Skip to contentSkip to conversation

Patch "can: fix handling of unmodifiable configuration options fix" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Aug 8, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

can: fix handling of unmodifiable configuration options fix

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
can-fix-handling-of-unmodifiable-configuration-options-fix.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From bce271f255dae8335dc4d2ee2c4531e09cc67f5a Mon Sep 17 00:00:00 2001

From: Oliver Hartkopp <[email protected]>
Date: Tue, 21 Jun 2016 12:14:07 +0200
Subject: can: fix handling of unmodifiable configuration options fix

From: Oliver Hartkopp <[email protected]>

commit bce271f255dae8335dc4d2ee2c4531e09cc67f5a upstream.

With upstream commit bb208f144cf3f59 (can: fix handling of unmodifiable configuration options) a new can_validate() function was introduced.

When invoking 'ip link set can0 type can' without any configuration data can_validate() tries to validate the content without taking into account that there's totally no content. This patch adds a check for missing content.

---
 drivers/net/can/dev.c |    3 +++
 1 file changed, 3 insertions(+)
drivers/net/can/dev.c +3 -0
@@ -798,6 +798,9 @@ static int can_validate(struct nlattr *t
 	 * - control mode with CAN_CTRLMODE_FD set
 	 */
 
+	if (!data)
+		return 0;
+
 	if (data[IFLA_CAN_CTRLMODE]) {
 		struct can_ctrlmode *cm = nla_data(data[IFLA_CAN_CTRLMODE]);
 

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/can-fix-oops-caused-by-wrong-rtnl-dellink-usage.patch queue-4.4/can-fix-handling-of-unmodifiable-configuration-options-fix.patch