Skip to contentSkip to conversation

Patch "qed: Fix setting/clearing bit in completion bitmap" has been added to the 4.6-stable tree

PATCH [email protected] 1 participant 1 message Aug 12, 2016

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

qed: Fix setting/clearing bit in completion bitmap

to the 4.6-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
qed-fix-setting-clearing-bit-in-completion-bitmap.patch
and it can be found in the queue-4.6 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Fri Aug 12 09:34:33 CEST 2016

From: Manish Chopra <[email protected]>
Date: Mon, 25 Jul 2016 19:07:46 +0300
Subject: qed: Fix setting/clearing bit in completion bitmap

From: Manish Chopra <[email protected]>

[ Upstream commit 59d3f1ceb69b54569685d0c34dff16a1e0816b19 ]

Slowpath completion handling is incorrectly changing SPQ_RING_SIZE bits instead of a single one.

Fixes 76a9a3642a0b ("qed: fix handling of concurrent ramrods")
---
 drivers/net/ethernet/qlogic/qed/qed_spq.c |    7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/net/ethernet/qlogic/qed/qed_spq.c +3 -4
@@ -791,13 +791,12 @@ int qed_spq_completion(struct qed_hwfn *
 			 * in a bitmap and increasing the chain consumer only
 			 * for the first successive completed entries.
 			 */
-			bitmap_set(p_spq->p_comp_bitmap, pos, SPQ_RING_SIZE);
+			__set_bit(pos, p_spq->p_comp_bitmap);
 
 			while (test_bit(p_spq->comp_bitmap_idx,
 					p_spq->p_comp_bitmap)) {
-				bitmap_clear(p_spq->p_comp_bitmap,
-					     p_spq->comp_bitmap_idx,
-					     SPQ_RING_SIZE);
+				__clear_bit(p_spq->comp_bitmap_idx,
+					    p_spq->p_comp_bitmap);
 				p_spq->comp_bitmap_idx++;
 				qed_chain_return_produced(&p_spq->chain);
 			}

Patches currently in stable-queue which might be from [email protected] are

queue-4.6/qed-fix-setting-clearing-bit-in-completion-bitmap.patch