Skip to contentSkip to conversation

kernel.bbclass: include signing keys when copying files required for module builds

PATCH Superseded Waldo Mattias 3 participants 4 messages Aug 12, 2016 – Aug 25, 2016

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kernel.bbclass: include signing keys when copying files required for module builds

The absence of certs/signing_key.* in $kerneldir made signing of out-of-tree kernel modules fail (silently). Add copying of these files during the shared_workdir task.

---
 meta/classes/kernel.bbclass | 2 ++
 1 file changed, 2 insertions(+)
meta/classes/kernel.bbclass +2 -0
index 6e3e81e..2bfd65c 100644
@@ -295,6 +295,8 @@ do_shared_workdir () {
        cp .config $kerneldir/
        mkdir -p $kerneldir/include/config
        cp include/config/kernel.release $kerneldir/include/config/kernel.release
+       mkdir -p $kerneldir/certs
+       cp certs/signing_key.* $kerneldir/certs
 
        # We can also copy over all the generated files and avoid special cases
        # like version.h, but we've opted to keep this small until file creep starts

--
2.9.2

#1 lore raw

Bruce,
Ping~~~
Could you or anyone have a look on this patch? It is for https://bugzilla.yoctoproject.org/show_bug.cgi?id=9805

Thanks

Quoted 35 lines · Waldo Mattias

The absence of certs/signing_key.* in $kerneldir made signing of out-of-tree kernel modules fail (silently). Add copying of these files during the shared_workdir task.

---
meta/classes/kernel.bbclass | 2 ++

1 file changed, 2 insertions(+)
meta/classes/kernel.bbclass +2 -1
index 6e3e81e..2bfd65c 100644
@@ -295,6 +295,8 @@ do_shared_workdir () {
       cp .config $kerneldir/
       mkdir -p $kerneldir/include/config
       cp include/config/kernel.release $kerneldir/include/config/kernel.release
+       mkdir -p $kerneldir/certs
+       cp certs/signing_key.* $kerneldir/certs
 
       # We can also copy over all the generated files and avoid special cases
       # like version.h, but we've opted to keep this small until file creep starts
--

2.9.2

Signature · 4 lines
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
#2 lore raw
In reply to Waldo Mattias
Quoted 4 lines · Waldo Mattias

The absence of certs/signing_key.* in $kerneldir made signing of out-of-tree kernel modules fail (silently). Add copying of these files during the shared_workdir task.

This doesn't apply to current master, can you rebase and resend?

Ross

#3 lore raw

Hi!

I’ve rebased successfully and resubmitted v2 of the patch – it doesn’t seem to have changed much, though – perhaps I misunderstood your intent? (Please bear with me, this is my first patch ever, so I may miss some obvious things...)

Regards,

Mattias

From: Burton, Ross [mailto:[email protected]]
Sent: den 24 augusti 2016 23:06
To: Waldo Mattias <[email protected]>
Cc: [email protected]
Subject: Re: [OE-core] [PATCH] kernel.bbclass: include signing keys when copying files required for module builds

On 12 August 2016 at 15:10, Waldo Mattias <[email protected]<mailto:[email protected]>> wrote:
The absence of certs/signing_key.* in $kerneldir made signing of
out-of-tree kernel modules fail (silently). Add copying of these files
during the shared_workdir task.

This doesn't apply to current master, can you rebase and resend?

Ross