Skip to contentSkip to conversation

Patch "KEYS: 64-bit MIPS needs to use compat_sys_keyctl for 32-bit userspace" has been added to the 3.14-stable tree

PATCH [email protected] 1 participant 1 message Aug 14, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

KEYS: 64-bit MIPS needs to use compat_sys_keyctl for 32-bit userspace

to the 3.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
keys-64-bit-mips-needs-to-use-compat_sys_keyctl-for-32-bit-userspace.patch
and it can be found in the queue-3.14 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 20f06ed9f61a185c6dabd662c310bed6189470df Mon Sep 17 00:00:00 2001

From: David Howells <[email protected]>
Date: Wed, 27 Jul 2016 11:43:37 +0100
Subject: KEYS: 64-bit MIPS needs to use compat_sys_keyctl for 32-bit userspace

From: David Howells <[email protected]>

commit 20f06ed9f61a185c6dabd662c310bed6189470df upstream.

MIPS64 needs to use compat_sys_keyctl for 32-bit userspace rather than calling sys_keyctl. The latter will work in a lot of cases, thereby hiding the issue.

Patchwork: https://patchwork.linux-mips.org/patch/13832/

---
 arch/mips/kernel/scall64-n32.S |    2 +-
 arch/mips/kernel/scall64-o32.S |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
arch/mips/kernel/scall64-n32.S +1 -1
@@ -350,7 +350,7 @@ EXPORT(sysn32_call_table)
 	PTR	sys_ni_syscall			/* available, was setaltroot */
 	PTR	sys_add_key
 	PTR	sys_request_key
-	PTR	sys_keyctl			/* 6245 */
+	PTR	compat_sys_keyctl		/* 6245 */
 	PTR	sys_set_thread_area
 	PTR	sys_inotify_init
 	PTR	sys_inotify_add_watch
arch/mips/kernel/scall64-o32.S +1 -1
@@ -474,7 +474,7 @@ EXPORT(sys32_call_table)
 	PTR	sys_ni_syscall			/* available, was setaltroot */
 	PTR	sys_add_key			/* 4280 */
 	PTR	sys_request_key
-	PTR	sys_keyctl
+	PTR	compat_sys_keyctl
 	PTR	sys_set_thread_area
 	PTR	sys_inotify_init
 	PTR	sys_inotify_add_watch		/* 4285 */

Patches currently in stable-queue which might be from [email protected] are

queue-3.14/keys-64-bit-mips-needs-to-use-compat_sys_keyctl-for-32-bit-userspace.patch