Skip to contentSkip to conversation

Patch "fuse: fuse_flush must check mapping->flags for errors" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Aug 14, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

    fuse: fuse_flush must check mapping->flags for errors

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
fuse-fuse_flush-must-check-mapping-flags-for-errors.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 9ebce595f63a407c5cec98f98f9da8459b73740a Mon Sep 17 00:00:00 2001

From: Maxim Patlasov <[email protected]>
Date: Tue, 19 Jul 2016 18:12:26 -0700
Subject: fuse: fuse_flush must check mapping->flags for errors

From: Maxim Patlasov <[email protected]>

commit 9ebce595f63a407c5cec98f98f9da8459b73740a upstream.

fuse_flush() calls write_inode_now() that triggers writeback, but actual writeback will happen later, on fuse_sync_writes(). If an error happens, fuse_writepage_end() will set error bit in mapping->flags. So, we have to check mapping->flags after fuse_sync_writes().

Fixes 4d99ff8f12eb ("fuse: Turn writeback cache on")
---
 fs/fuse/file.c |    9 +++++++++
 1 file changed, 9 insertions(+)
fs/fuse/file.c +9 -0
@@ -417,6 +417,15 @@ static int fuse_flush(struct file *file,
 	fuse_sync_writes(inode);
 	mutex_unlock(&inode->i_mutex);
 
+	if (test_bit(AS_ENOSPC, &file->f_mapping->flags) &&
+	    test_and_clear_bit(AS_ENOSPC, &file->f_mapping->flags))
+		err = -ENOSPC;
+	if (test_bit(AS_EIO, &file->f_mapping->flags) &&
+	    test_and_clear_bit(AS_EIO, &file->f_mapping->flags))
+		err = -EIO;
+	if (err)
+		return err;
+
 	req = fuse_get_req_nofail_nopages(fc, file);
 	memset(&inarg, 0, sizeof(inarg));
 	inarg.fh = ff->fh;

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/fuse-fsync-did-not-return-io-errors.patch queue-4.4/fuse-fuse_flush-must-check-mapping-flags-for-errors.patch