Skip to contentSkip to conversation

Patch "gpio: intel-mid: switch to devm_gpiochip_add_data()" has been added to the 4.7-stable tree

PATCH [email protected] 1 participant 1 message Aug 18, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

gpio: intel-mid: switch to devm_gpiochip_add_data()

to the 4.7-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
gpio-intel-mid-switch-to-devm_gpiochip_add_data.patch
and it can be found in the queue-4.7 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From dd3b204af11b50be6dc77e18b88b3c646bba354c Mon Sep 17 00:00:00 2001

From: Andy Shevchenko <[email protected]>
Date: Sun, 19 Jun 2016 23:49:57 +0300
Subject: gpio: intel-mid: switch to devm_gpiochip_add_data()

From: Andy Shevchenko <[email protected]>

commit dd3b204af11b50be6dc77e18b88b3c646bba354c upstream.

The error handling is not correct since the commit 3f7dbfd8eea9 ("gpio:
intel-mid: switch to using gpiolib irqchip helpers"). Switch to devres API to fix the potential resource leak.

Fixes commit 3f7dbfd8eea9 ("gpio: intel-mid: switch to using gpiolib irqchip helpers")
---
 drivers/gpio/gpio-intel-mid.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpio/gpio-intel-mid.c +1 -1
@@ -382,7 +382,7 @@ static int intel_gpio_probe(struct pci_d
 	spin_lock_init(&priv->lock);
 
 	pci_set_drvdata(pdev, priv);
-	retval = gpiochip_add_data(&priv->chip, priv);
+	retval = devm_gpiochip_add_data(&pdev->dev, &priv->chip, priv);
 	if (retval) {
 		dev_err(&pdev->dev, "gpiochip_add error %d\n", retval);
 		return retval;

Patches currently in stable-queue which might be from [email protected] are

queue-4.7/gpio-intel-mid-remove-potentially-harmful-code.patch queue-4.7/gpio-intel-mid-switch-to-devm_gpiochip_add_data.patch