Skip to contentSkip to conversation

Patch "i2c: efm32: fix a failure path in efm32_i2c_probe()" has been added to the 4.7-stable tree

PATCH [email protected] 1 participant 1 message Aug 18, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

i2c: efm32: fix a failure path in efm32_i2c_probe()

to the 4.7-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:

     i2c-efm32-fix-a-failure-path-in-efm32_i2c_probe.patch

and it can be found in the queue-4.7 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 7dd91d52a813f99a95d20f539b777e9e6198b931 Mon Sep 17 00:00:00 2001

From: Alexey Khoroshilov <[email protected]>
Date: Sat, 16 Jul 2016 02:36:38 +0300
Subject: i2c: efm32: fix a failure path in efm32_i2c_probe()
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Alexey Khoroshilov <[email protected]>

commit 7dd91d52a813f99a95d20f539b777e9e6198b931 upstream.

There is the only failure path in efm32_i2c_probe(), where clk_disable_unprepare() is missed.

Found by Linux Driver Verification project (linuxtesting.org).

Fixes 1b5b23718b84 ("i2c: efm32: new bus driver")
---
 drivers/i2c/busses/i2c-efm32.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/i2c/busses/i2c-efm32.c +1 -1
@@ -433,7 +433,7 @@ static int efm32_i2c_probe(struct platfo
 	ret = request_irq(ddata->irq, efm32_i2c_irq, 0, DRIVER_NAME, ddata);
 	if (ret < 0) {
 		dev_err(&pdev->dev, "failed to request irq (%d)\n", ret);
-		return ret;
+		goto err_disable_clk;
 	}
 
 	ret = i2c_add_adapter(&ddata->adapter);

Patches currently in stable-queue which might be from [email protected] are

queue-4.7/i2c-efm32-fix-a-failure-path-in-efm32_i2c_probe.patch