Patch "MIPS: KVM: Propagate kseg0/mapped tlb fault errors" has been added to the 4.7-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
MIPS: KVM: Propagate kseg0/mapped tlb fault errors
to the 4.7-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
mips-kvm-propagate-kseg0-mapped-tlb-fault-errors.patch
and it can be found in the queue-4.7 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
9b731bcfdec4c159ad2e4312e25d69221709b96aMon Sep 17 00:00:00 2001
From: James Hogan <[email protected]>
Date: Thu, 11 Aug 2016 11:58:15 +0100
Subject: MIPS: KVM: Propagate kseg0/mapped tlb fault errors
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
From: James Hogan <[email protected]>
commit 9b731bcfdec4c159ad2e4312e25d69221709b96a upstream.
Propagate errors from kvm_mips_handle_kseg0_tlb_fault() and kvm_mips_handle_mapped_seg_tlb_fault(), usually triggering an internal error since they normally indicate the guest accessed bad physical memory or the commpage in an unexpected way.
--- arch/mips/kvm/emulate.c | 40 ++++++++++++++++++++++++++++------------ arch/mips/kvm/tlb.c | 14 ++++++++++---- 2 files changed, 38 insertions(+), 16 deletions(-)
arch/mips/kvm/emulate.c +28 -12
@@ -1615,8 +1615,14 @@ enum emulation_result kvm_mips_emulate_cpreempt_disable ();if (KVM_GUEST_KSEGX (va) ==KVM_GUEST_KSEG0 ) { -if (kvm_mips_host_tlb_lookup (vcpu, va) <0 ) -kvm_mips_handle_kseg0_tlb_fault (va, vcpu); +if (kvm_mips_host_tlb_lookup (vcpu, va) <0 && +kvm_mips_handle_kseg0_tlb_fault (va, vcpu)) { +kvm_err ("%s: handling mapped kseg0 tlb fault for %lx, vcpu: %p, ASID: %#lx\n" , + __func__, va, vcpu,read_c0_entryhi ()); + er =EMULATE_FAIL ; +preempt_enable (); + goto done; + } }else if ((KVM_GUEST_KSEGX (va) <KVM_GUEST_KSEG0 ) ||KVM_GUEST_KSEGX (va) ==KVM_GUEST_KSEG23 ) {int index;
@@ -1654,14 +1660,19 @@ enum emulation_result kvm_mips_emulate_c run, vcpu);preempt_enable (); goto dont_update_pc; - }else { -/* -* We fault an entry from the guest tlb to the -* shadow host TLB -*/ -kvm_mips_handle_mapped_seg_tlb_fault (vcpu, tlb, -NULL , -NULL ); + } +/* +* We fault an entry from the guest tlb to the +* shadow host TLB +*/ +if (kvm_mips_handle_mapped_seg_tlb_fault (vcpu, tlb, +NULL ,NULL )) { +kvm_err ("%s: handling mapped seg tlb fault for %lx, index: %u, vcpu: %p, ASID: %#lx\n" , + __func__, va, index, vcpu, +read_c0_entryhi ()); + er =EMULATE_FAIL ; +preempt_enable (); + goto done; } } }else {
@@ -2625,8 +2636,13 @@ enum emulation_result kvm_mips_handle_tl* OK we have a Guest TLB entry, now inject it into the * shadow host TLB */ -kvm_mips_handle_mapped_seg_tlb_fault (vcpu, tlb,NULL , -NULL ); +if (kvm_mips_handle_mapped_seg_tlb_fault (vcpu, tlb, +NULL ,NULL )) { +kvm_err ("%s: handling mapped seg tlb fault for %lx, index: %u, vcpu: %p, ASID: %#lx\n" , + __func__, va, index, vcpu, +read_c0_entryhi ()); + er =EMULATE_FAIL ; + } } }
arch/mips/kvm/tlb.c +10 -4
@@ -790,10 +790,16 @@ uint32_t kvm_get_inst(uint32_t *opc, strlocal_irq_restore (flags);return KVM_INVALID_INST ; } -kvm_mips_handle_mapped_seg_tlb_fault (vcpu, - &vcpu->arch. - guest_tlb[index], -NULL ,NULL ); +if (kvm_mips_handle_mapped_seg_tlb_fault (vcpu, + &vcpu->arch.guest_tlb[index], +NULL ,NULL )) { +kvm_err ("%s: handling mapped seg tlb fault failed for %p, index: %u, vcpu: %p, ASID: %#lx\n" , + __func__, opc, index, vcpu, +read_c0_entryhi ()); +kvm_mips_dump_guest_tlbs (vcpu); +local_irq_restore (flags); +return KVM_INVALID_INST ; + } inst = *(opc); }local_irq_restore (flags);
Patches currently in stable-queue which might be from [email protected] are
queue-4.7/mips-kvm-add-missing-gfn-range-check.patch queue-4.7/mips-kvm-propagate-kseg0-mapped-tlb-fault-errors.patch queue-4.7/mips-kvm-fix-mapped-fault-broken-commpage-handling.patch queue-4.7/mips-kvm-fix-gfn-range-check-in-kseg0-tlb-faults.patch