Skip to contentSkip to conversation

Fix amdgpu_dri2_exchange_buffers width/height miss copy

PATCH In review Qiang Yu 3 participants 3 messages Aug 22, 2016 – Aug 23, 2016 1 message not in the archive

lore
Share & tools
lore

Qiang Yu

author
#0 lore raw

PATCH 1/1 Fix amdgpu_dri2_exchange_buffers width/height miss copy

---
 src/amdgpu_dri2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
src/amdgpu_dri2.c +1 -1
index 03e3a0b..de701c2 100644
@@ -665,7 +665,7 @@ amdgpu_dri2_exchange_buffers(DrawablePtr draw, DRI2BufferPtr front,
 
 	region.extents.x1 = region.extents.y1 = 0;
 	region.extents.x2 = front_priv->pixmap->drawable.width;
-	region.extents.y2 = front_priv->pixmap->drawable.width;
+	region.extents.y2 = front_priv->pixmap->drawable.height;
 	region.data = NULL;
 	DamageRegionAppend(&front_priv->pixmap->drawable, &region);
 
Signature · 6 lines
1.9.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1471864406-25978-1-git-send-email-Qiang.Yu-5C7GfCeVMHo@public.gmane.org

Reviewed-by Alex Deucher
#2 lore raw
Quoted 10 lines

-----Original Message-----
From: amd-gfx [mailto:[email protected]] On Behalf Of Qiang Yu
Sent: Monday, August 22, 2016 7:13 AM
To: [email protected]
Cc: Yu, Qiang
Subject: [PATCH xf86-video-amdgpu] Fix amdgpu_dri2_exchange_buffers width/height miss copy

Quoted 21 lines
---
 src/amdgpu_dri2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
src/amdgpu_dri2.c +1 -2
index 03e3a0b..de701c2 100644
@@ -665,7 +665,7 @@ amdgpu_dri2_exchange_buffers(DrawablePtr draw,
 DRI2BufferPtr front,
 
 	region.extents.x1 = region.extents.y1 = 0;
 	region.extents.x2 = front_priv->pixmap->drawable.width;
-	region.extents.y2 = front_priv->pixmap->drawable.width;
+	region.extents.y2 = front_priv->pixmap->drawable.height;
 	region.data = NULL;
 	DamageRegionAppend(&front_priv->pixmap->drawable, &region);
 
--

1.9.1

Quoted 4 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

#3 lore raw
In reply to a message not in the archive
Quoted 11 lines · Qiang Yu
---
 src/amdgpu_dri2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
src/amdgpu_dri2.c +0 -0
index 03e3a0b..de701c2 100644

src/amdgpu_dri2.c amdgpu_dri2_exchange_buffers(DrawablePtr draw, DRI2BufferPtr front, · line 671

Quoted 8 lines
src/amdgpu_dri2.c +1 -1
@@ -665,7 +665,7 @@ amdgpu_dri2_exchange_buffers(DrawablePtr draw, DRI2BufferPtr front,
 
 	region.extents.x1 = region.extents.y1 = 0;
 	region.extents.x2 = front_priv->pixmap->drawable.width;
-	region.extents.y2 = front_priv->pixmap->drawable.width;
+	region.extents.y2 = front_priv->pixmap->drawable.height;
 	region.data = NULL;
 	DamageRegionAppend(&front_priv->pixmap->drawable, &region);
 

Reviewed and pushed, thanks!

Signature · 6 lines
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx