drm/amdgpu: fix the wrong value of UVD bo size
Subsystems (2)
PATCH 1/1 drm/amdgpu: fix the wrong value of UVD bo size
Driver allocate bo for restore UVD fw ,cache, stack , etc. the firmware size is not only ucode size but the ucode and header.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c +1 -1
@@ -198,7 +198,7 @@ int amdgpu_uvd_sw_init(struct amdgpu_device *adev)DRM_ERROR ("POLARIS10/11 UVD firmware version %hu.%hu is too old.\n" , version_major, version_minor); - bo_size =AMDGPU_GPU_PAGE_ALIGN (le32_to_cpu (hdr->ucode_size_bytes) +8 ) + bo_size =AMDGPU_GPU_PAGE_ALIGN (le32_to_cpu (adev->uvd.fw->size) +8 ) +AMDGPU_UVD_STACK_SIZE +AMDGPU_UVD_HEAP_SIZE +AMDGPU_UVD_SESSION_SIZE * adev->uvd.max_handles; r = amdgpu_bo_create_kernel(adev, bo_size, PAGE_SIZE,
Signature · 6 lines
1.9.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 1471933228-23515-1-git-send-email-Jim.Qu-5C7GfCeVMHo@public.gmane.org
Am 23.08.2016 um 08:20 schrieb jimqu:
Quoted 2 lines
Driver allocate bo for restore UVD fw ,cache, stack , etc. the firmware size is not only ucode size but the ucode and header.
Nope that isn't correct. Only the firmware is copied to the BO, not the header. See amdgpu_uvd_resume().
Saying this we should probably use the length from the header instead of calculating it manually again in amdgpu_uvd_resume().
Christian.
Quoted 12 lines
Change-Id I886c099fa123c4814de9b7db3559c30e7b41fd1bSigned-off-by JimQu <[email protected]>--- drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c +0
-0
drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c int amdgpu_uvd_sw_init(struct amdgpu_device *adev) · line 204
Quoted 8 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c +1
-1@@ -198,7 +198,7 @@ int amdgpu_uvd_sw_init(struct amdgpu_device *adev)DRM_ERROR ("POLARIS10/11 UVD firmware version %hu.%hu is too old.\n" , version_major, version_minor); - bo_size =AMDGPU_GPU_PAGE_ALIGN (le32_to_cpu (hdr->ucode_size_bytes) +8 ) + bo_size =AMDGPU_GPU_PAGE_ALIGN (le32_to_cpu (adev->uvd.fw->size) +8 ) +AMDGPU_UVD_STACK_SIZE +AMDGPU_UVD_HEAP_SIZE +AMDGPU_UVD_SESSION_SIZE * adev->uvd.max_handles; r = amdgpu_bo_create_kernel(adev, bo_size, PAGE_SIZE,
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 149ffeec-251d-0f76-0442-a32430536eb7-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org
Hi Christian:
Yes, I have misunderstand the AMDGPU_UVD_FIRMWARE_OFFSET in amdgpu_uvd_mc_resume().
I will update the patch.
Thanks
JimQu
________________________________________
发件人: Christian König <[email protected]>
发送时间: 2016年8月23日 16:02:11
收件人: Qu, Jim; [email protected]
主题: Re: [PATCH] drm/amdgpu: fix the wrong value of UVD bo size
Am 23.08.2016 um 08:20 schrieb jimqu:
Quoted 2 lines
Driver allocate bo for restore UVD fw ,cache, stack , etc. the firmware size is not only ucode size but the ucode and header.
Nope that isn't correct. Only the firmware is copied to the BO, not the header. See amdgpu_uvd_resume().
Saying this we should probably use the length from the header instead of calculating it manually again in amdgpu_uvd_resume().
Christian.
Quoted 12 lines
Change-Id I886c099fa123c4814de9b7db3559c30e7b41fd1bSigned-off-by JimQu <[email protected]>--- drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c +0
-0
drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c int amdgpu_uvd_sw_init(struct amdgpu_device *adev) · line 204
Quoted 8 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c +1
-1@@ -198,7 +198,7 @@ int amdgpu_uvd_sw_init(struct amdgpu_device *adev)DRM_ERROR ("POLARIS10/11 UVD firmware version %hu.%hu is too old.\n" , version_major, version_minor); - bo_size =AMDGPU_GPU_PAGE_ALIGN (le32_to_cpu (hdr->ucode_size_bytes) +8 ) + bo_size =AMDGPU_GPU_PAGE_ALIGN (le32_to_cpu (adev->uvd.fw->size) +8 ) +AMDGPU_UVD_STACK_SIZE +AMDGPU_UVD_HEAP_SIZE +AMDGPU_UVD_SESSION_SIZE * adev->uvd.max_handles; r = amdgpu_bo_create_kernel(adev, bo_size, PAGE_SIZE,
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): BY2PR12MB06142C9FB06F7E1AF19619E599EB0-K//h7OWB4q5SmL+xRiD5tgdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org
Quoted 1 line
I will update the patch.
Let me do this. I already had a couple of other TODOs on this part of the code.
Christian.
Am 23.08.2016 um 10:33 schrieb Qu, Jim:
Quoted 40 lines
Hi Christian:
Yes, I have misunderstand the
AMDGPU_UVD_FIRMWARE_OFFSETinamdgpu_uvd_mc_resume().I will update the patch.
Thanks
JimQu________________________________________
发件人: Christian König <[email protected]>
发送时间: 2016年8月23日 16:02:11
收件人: Qu, Jim; [email protected]
主题: Re: [PATCH] drm/amdgpu: fix the wrong value of UVD bo sizeAm 23.08.2016 um 08:20 schrieb jimqu:
Quoted 2 lines
Driver allocate bo for restore UVD fw ,cache, stack , etc. the firmware size is not only ucode size but the ucode and header.
Nope that isn't correct. Only the firmware is copied to the BO, not the header. See
amdgpu_uvd_resume().Saying this we should probably use the length from the header instead of calculating it manually again in
amdgpu_uvd_resume().Christian.
Quoted 14 lines
Change-Id I886c099fa123c4814de9b7db3559c30e7b41fd1bSigned-off-by JimQu <[email protected]>--- drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c +0
-0@@ -198,7 +198,7 @@ int amdgpu_uvd_sw_init(struct amdgpu_device *adev)DRM_ERROR ("POLARIS10/11 UVD firmware version %hu.%hu is too old.\n" , version_major, version_minor);
Quoted 10 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c int amdgpu_uvd_sw_init(struct amdgpu_device *adev) · line 204
Quoted 5 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c +1
-1- bo_size =AMDGPU_GPU_PAGE_ALIGN (le32_to_cpu (hdr->ucode_size_bytes) +8 ) + bo_size =AMDGPU_GPU_PAGE_ALIGN (le32_to_cpu (adev->uvd.fw->size) +8 ) +AMDGPU_UVD_STACK_SIZE +AMDGPU_UVD_HEAP_SIZE +AMDGPU_UVD_SESSION_SIZE * adev->uvd.max_handles; r = amdgpu_bo_create_kernel(adev, bo_size, PAGE_SIZE,_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): a9e6da05-5977-0cbc-eecc-ac6462554325-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org
OK.
Thanks
JimQu
________________________________________
发件人: Christian König <[email protected]>
发送时间: 2016年8月23日 16:53:50
收件人: Qu, Jim; [email protected]
主题: Re: 答复: [PATCH] drm/amdgpu: fix the wrong value of UVD bo size
Quoted 1 line
I will update the patch.
Let me do this. I already had a couple of other TODOs on this part of the code.
Christian.
Am 23.08.2016 um 10:33 schrieb Qu, Jim:
Quoted 40 lines
Hi Christian:
Yes, I have misunderstand the
AMDGPU_UVD_FIRMWARE_OFFSETinamdgpu_uvd_mc_resume().I will update the patch.
Thanks
JimQu________________________________________
发件人: Christian König <[email protected]>
发送时间: 2016年8月23日 16:02:11
收件人: Qu, Jim; [email protected]
主题: Re: [PATCH] drm/amdgpu: fix the wrong value of UVD bo sizeAm 23.08.2016 um 08:20 schrieb jimqu:
Quoted 2 lines
Driver allocate bo for restore UVD fw ,cache, stack , etc. the firmware size is not only ucode size but the ucode and header.
Nope that isn't correct. Only the firmware is copied to the BO, not the header. See
amdgpu_uvd_resume().Saying this we should probably use the length from the header instead of calculating it manually again in
amdgpu_uvd_resume().Christian.
Quoted 14 lines
Change-Id I886c099fa123c4814de9b7db3559c30e7b41fd1bSigned-off-by JimQu <[email protected]>--- drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c +0
-0@@ -198,7 +198,7 @@ int amdgpu_uvd_sw_init(struct amdgpu_device *adev)DRM_ERROR ("POLARIS10/11 UVD firmware version %hu.%hu is too old.\n" , version_major, version_minor);
Quoted 10 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c int amdgpu_uvd_sw_init(struct amdgpu_device *adev) · line 204
Quoted 5 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c +1
-1- bo_size =AMDGPU_GPU_PAGE_ALIGN (le32_to_cpu (hdr->ucode_size_bytes) +8 ) + bo_size =AMDGPU_GPU_PAGE_ALIGN (le32_to_cpu (adev->uvd.fw->size) +8 ) +AMDGPU_UVD_STACK_SIZE +AMDGPU_UVD_HEAP_SIZE +AMDGPU_UVD_SESSION_SIZE * adev->uvd.max_handles; r = amdgpu_bo_create_kernel(adev, bo_size, PAGE_SIZE,_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx