drm/i915: use offset value in DRM_DEBUG_KMS
Subsystems (2)
PATCH 1/1 drm/i915: use offset value in DRM_DEBUG_KMS
We go through all the trouble of reading the offset from hw, but never end up using it. Later in the DRM_DEBUG_KMS statement we mistakenly use the base as the offset. Let's fix this by now making use of both the offset and the base, and while we are here make the format more consistent.
--- drivers/gpu/drm/i915/intel_display.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/gpu/drm/i915/intel_display.c +6 -6
@@ -8765,9 +8765,9 @@ i9xx_get_initial_plane_config(struct intel_crtc *crtc, plane_config->size = fb->pitches[0 ] * aligned_height; -DRM_DEBUG_KMS ("pipe/plane %c/%d with fb: size=%dx%d@%d, offset=%x, pitch %d, size 0x%x\n" , +DRM_DEBUG_KMS ("pipe/plane %c/%d with fb: size=%dx%d@%d, base=%x, offset=%x, pitch=%d, size=0x%x\n" ,pipe_name (pipe), plane, fb->width, fb->height, - fb->bits_per_pixel, base, fb->pitches[0 ], + fb->bits_per_pixel, base, offset, fb->pitches[0 ], plane_config->size); plane_config->fb = intel_fb;
@@ -9789,9 +9789,9 @@ skylake_get_initial_plane_config(struct intel_crtc *crtc, plane_config->size = fb->pitches[0 ] * aligned_height; -DRM_DEBUG_KMS ("pipe %c with fb: size=%dx%d@%d, offset=%x, pitch %d, size 0x%x\n" , +DRM_DEBUG_KMS ("pipe %c with fb: size=%dx%d@%d, base=%x, offset=%x, pitch=%d, size=0x%x\n" ,pipe_name (pipe), fb->width, fb->height, - fb->bits_per_pixel, base, fb->pitches[0 ], + fb->bits_per_pixel, base, offset, fb->pitches[0 ], plane_config->size); plane_config->fb = intel_fb;
@@ -9886,9 +9886,9 @@ ironlake_get_initial_plane_config(struct intel_crtc *crtc, plane_config->size = fb->pitches[0 ] * aligned_height; -DRM_DEBUG_KMS ("pipe %c with fb: size=%dx%d@%d, offset=%x, pitch %d, size 0x%x\n" , +DRM_DEBUG_KMS ("pipe %c with fb: size=%dx%d@%d, base=%x, offset=%x, pitch=%d, size=0x%x\n" ,pipe_name (pipe), fb->width, fb->height, - fb->bits_per_pixel, base, fb->pitches[0 ], + fb->bits_per_pixel, base, offset, fb->pitches[0 ], plane_config->size); plane_config->fb = intel_fb;
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.BAT: failure for drm/i915: use offset value in DRM_DEBUG_KMS
== Series Details ==
== Series Details ==
Series: drm/i915: use offset value in DRM_DEBUG_KMS
URL : https://patchwork.freedesktop.org/series/11476/
State : failure
== Summary ==
Series 11476v1 drm/i915: use offset value in DRM_DEBUG_KMS
http://patchwork.freedesktop.org/api/1.0/series/11476/revisions/1/mbox/
Test gem_exec_suspend:
Subgroup basic-s3:
incomplete -> DMESG-WARN (fi-hsw-4770k)
Test kms_cursor_legacy:
Subgroup basic-flip-vs-cursor-legacy:
pass -> FAIL (fi-bsw-n3050)
fail -> PASS (fi-skl-6700k)
Subgroup basic-flip-vs-cursor-varying-size:
fail -> PASS (fi-skl-6700k)fi-bdw-5557u total:249 pass:231 dwarn:0 dfail:0 fail:2 skip:16 fi-bsw-n3050 total:249 pass:202 dwarn:0 dfail:0 fail:3 skip:44 fi-byt-n2820 total:249 pass:204 dwarn:0 dfail:0 fail:4 skip:41 fi-hsw-4770k total:249 pass:220 dwarn:6 dfail:0 fail:1 skip:22 fi-hsw-4770r total:249 pass:222 dwarn:0 dfail:0 fail:1 skip:26 fi-ivb-3520m total:249 pass:217 dwarn:0 dfail:0 fail:1 skip:31 fi-skl-6260u total:249 pass:234 dwarn:0 dfail:0 fail:1 skip:14 fi-skl-6700k total:249 pass:216 dwarn:4 dfail:0 fail:1 skip:28 fi-snb-2520m total:249 pass:201 dwarn:4 dfail:0 fail:2 skip:42 fi-snb-2600 total:249 pass:202 dwarn:4 dfail:0 fail:1 skip:42
Results at /archive/results/CI_IGT_test/Patchwork_2410/
d05ed1828321404c7fdf369ca17fa958938913bc drm-intel-nightly: 2016y-08m-23d-16h-32m-14s UTC integration manifest 9f91239 drm/i915: use offset value in DRM_DEBUG_KMS
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx