Skip to contentSkip to conversation

Patch "SUNRPC: Handle EADDRNOTAVAIL on connection failures" has been added to the 4.7-stable tree

PATCH [email protected] 1 participant 1 message Aug 30, 2016

Subsystems (4)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

SUNRPC: Handle EADDRNOTAVAIL on connection failures

to the 4.7-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
sunrpc-handle-eaddrnotavail-on-connection-failures.patch
and it can be found in the queue-4.7 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 1f4c17a03ba7f430d63dba8c8e08ff1e2712581d Mon Sep 17 00:00:00 2001

From: Trond Myklebust <[email protected]>
Date: Mon, 1 Aug 2016 13:36:08 -0400
Subject: SUNRPC: Handle EADDRNOTAVAIL on connection failures

From: Trond Myklebust <[email protected]>

commit 1f4c17a03ba7f430d63dba8c8e08ff1e2712581d upstream.

If the connect attempt immediately fails with an EADDRNOTAVAIL error, then that means our choice of source port number was bad.
This error is expected when we set the SO_REUSEPORT socket option and we have 2 sockets sharing the same source and destination address and port combinations.

Fixes 402e23b4ed9ed ("SUNRPC: Fix stupid typo in xs_sock_set_reuseport")
---
 net/sunrpc/xprtsock.c |    4 ++++
 1 file changed, 4 insertions(+)
net/sunrpc/xprtsock.c +4 -0
@@ -2278,6 +2278,10 @@ static int xs_tcp_finish_connecting(stru
 		/* SYN_SENT! */
 		if (xprt->reestablish_timeout < XS_TCP_INIT_REEST_TO)
 			xprt->reestablish_timeout = XS_TCP_INIT_REEST_TO;
+		break;
+	case -EADDRNOTAVAIL:
+		/* Source port number is unavailable. Try a new one! */
+		transport->srcport = 0;
 	}
 out:
 	return ret;

Patches currently in stable-queue which might be from [email protected] are

queue-4.7/sunrpc-handle-eaddrnotavail-on-connection-failures.patch queue-4.7/sunrpc-allow-for-upcalls-for-same-uid-but-different-gss-service.patch