Skip to contentSkip to conversation

ASoC: arizona: Don't change the FLLn_GAIN before entering FREERUN

PATCH In review Charles Keepax 2 participants 2 messages Aug 30, 2016 – Aug 31, 2016

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: arizona: Don't change the FLLn_GAIN before entering FREERUN

From: Nariman Poushin <[email protected]>

When reclocking an active FLL, to ensure a clean transition, do not change the gain setting until we have entered free run.

---
 sound/soc/codecs/arizona.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
sound/soc/codecs/arizona.c +2 -2
index ecfdbfc..0fc3b4b 100644
@@ -2218,11 +2218,11 @@ static int arizona_enable_fll(struct arizona_fll *fll)
 
 	if (already_enabled) {
 		/* Facilitate smooth refclk across the transition */
-		regmap_update_bits_async(fll->arizona->regmap, fll->base + 0x9,
-					 ARIZONA_FLL1_GAIN_MASK, 0);
 		regmap_update_bits(fll->arizona->regmap, fll->base + 1,
 				   ARIZONA_FLL1_FREERUN, ARIZONA_FLL1_FREERUN);
 		udelay(32);
+		regmap_update_bits_async(fll->arizona->regmap, fll->base + 0x9,
+					 ARIZONA_FLL1_GAIN_MASK, 0);
 	}
 
 	/*
Signature · 1 line
2.1.4
maintainer
#1 lore raw

Applied "ASoC: arizona: Don't change the FLLn_GAIN before entering FREERUN" to the asoc tree

The patch

ASoC: arizona: Don't change the FLLn_GAIN before entering FREERUN

has been applied to the asoc tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From c9991052aedaa74c69f8198852c65a99caf1adec Mon Sep 17 00:00:00 2001

From: Nariman Poushin <[email protected]>
Date: Tue, 30 Aug 2016 10:30:40 +0100
Subject: [PATCH] ASoC: arizona: Don't change the FLLn_GAIN before entering
FREERUN

When reclocking an active FLL, to ensure a clean transition, do not change the gain setting until we have entered free run.

---
 sound/soc/codecs/arizona.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
sound/soc/codecs/arizona.c +2 -2
index ecfdbfcae366..0fc3b4b61552 100644
@@ -2218,11 +2218,11 @@ static int arizona_enable_fll(struct arizona_fll *fll)
 
 	if (already_enabled) {
 		/* Facilitate smooth refclk across the transition */
-		regmap_update_bits_async(fll->arizona->regmap, fll->base + 0x9,
-					 ARIZONA_FLL1_GAIN_MASK, 0);
 		regmap_update_bits(fll->arizona->regmap, fll->base + 1,
 				   ARIZONA_FLL1_FREERUN, ARIZONA_FLL1_FREERUN);
 		udelay(32);
+		regmap_update_bits_async(fll->arizona->regmap, fll->base + 0x9,
+					 ARIZONA_FLL1_GAIN_MASK, 0);
 	}
 
 	/*
Signature · 1 line
2.9.3