Skip to contentSkip to conversation

Patch "usb: chipidea: udc: don't touch DP when controller is in host mode" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Sep 5, 2016

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

usb: chipidea: udc: don't touch DP when controller is in host mode

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
usb-chipidea-udc-don-t-touch-dp-when-controller-is-in-host-mode.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From c4e94174983a86c935be1537a73e496b778b0287 Mon Sep 17 00:00:00 2001

From: Li Jun <[email protected]>
Date: Tue, 16 Aug 2016 19:19:11 +0800
Subject: usb: chipidea: udc: don't touch DP when controller is in host mode

From: Li Jun <[email protected]>

commit c4e94174983a86c935be1537a73e496b778b0287 upstream.

When the controller is configured to be dual role and it's in host mode, if bind udc and gadgt driver, those gadget operations will do gadget disconnect and finally pull down DP line, which will break host function.

---
 drivers/usb/chipidea/udc.c |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/usb/chipidea/udc.c +5 -2
@@ -1585,8 +1585,11 @@ static int ci_udc_pullup(struct usb_gadg
 {
 	struct ci_hdrc *ci = container_of(_gadget, struct ci_hdrc, gadget);
 
-	/* Data+ pullup controlled by OTG state machine in OTG fsm mode */
-	if (ci_otg_is_fsm_mode(ci))
+	/*
+	 * Data+ pullup controlled by OTG state machine in OTG fsm mode;
+	 * and don't touch Data+ in host mode for dual role config.
+	 */
+	if (ci_otg_is_fsm_mode(ci) || ci->role == CI_ROLE_HOST)
 		return 0;
 
 	pm_runtime_get_sync(&ci->gadget.dev);

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/usb-chipidea-udc-don-t-touch-dp-when-controller-is-in-host-mode.patch