Skip to contentSkip to conversation

Patch "staging: comedi: ni_mio_common: fix wrong insn_write handler" has been added to the 4.7-stable tree

PATCH [email protected] 1 participant 1 message Sep 5, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

staging: comedi: ni_mio_common: fix wrong insn_write handler

to the 4.7-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
staging-comedi-ni_mio_common-fix-wrong-insn_write-handler.patch
and it can be found in the queue-4.7 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 5ca05345c56cb979e1a25ab6146437002f95cac8 Mon Sep 17 00:00:00 2001

From: Ian Abbott <[email protected]>
Date: Wed, 20 Jul 2016 17:07:34 +0100
Subject: staging: comedi: ni_mio_common: fix wrong insn_write handler
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Ian Abbott <[email protected]>

commit 5ca05345c56cb979e1a25ab6146437002f95cac8 upstream.

For counter subdevices, the s->insn_write handler is being set to the wrong function, ni_tio_insn_read(). It should be ni_tio_insn_write().

Fixes 10f74377eec3 ("staging: comedi: ni_tio: make ni_tio_winsn() a

proper comedi (*insn_write)"

---
 drivers/staging/comedi/drivers/ni_mio_common.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/comedi/drivers/ni_mio_common.c +1 -1
@@ -5488,7 +5488,7 @@ static int ni_E_init(struct comedi_devic
 		s->maxdata	= (devpriv->is_m_series) ? 0xffffffff
 							 : 0x00ffffff;
 		s->insn_read	= ni_tio_insn_read;
-		s->insn_write	= ni_tio_insn_read;
+		s->insn_write	= ni_tio_insn_write;
 		s->insn_config	= ni_tio_insn_config;
 #ifdef PCIDMA
 		if (dev->irq && devpriv->mite) {

Patches currently in stable-queue which might be from [email protected] are

queue-4.7/staging-comedi-comedi_test-fix-timer-race-conditions.patch queue-4.7/staging-comedi-ni_mio_common-fix-ao-inttrig-backwards-compatibility.patch queue-4.7/staging-comedi-ni_mio_common-fix-wrong-insn_write-handler.patch queue-4.7/staging-comedi-daqboard2000-bug-fix-board-type-matching-code.patch